qapi/pragma.json: Improve the comment about the lists of QAPI rule exceptions

[PATCH] qapi/pragma.json: Improve the comment about the lists of QAPI rule exceptions

Thomas Huth posted 1 patch 1 year ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231113162928.54551-1-thuth@redhat.com

Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>

qapi/pragma.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] qapi/pragma.json: Improve the comment about the lists of QAPI rule exceptions

Posted by Thomas Huth 1 year ago

Let's use more inclusive language here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qapi/pragma.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/pragma.json b/qapi/pragma.json
index 7f810b0e97..0aa4eeddd3 100644
--- a/qapi/pragma.json
+++ b/qapi/pragma.json
@@ -3,8 +3,8 @@
 
 { 'pragma': { 'doc-required': true } }
 
-# Whitelists to permit QAPI rule violations; think twice before you
-# add to them!
+# Entries in these lists are allowed to violate the QAPI rules (for
+# historical reasons); think twice before you add to them!
 { 'pragma': {
     # Command names containing '_'
     'command-name-exceptions': [
-- 
2.41.0

Re: [PATCH] qapi/pragma.json: Improve the comment about the lists of QAPI rule exceptions

Posted by Eric Blake 1 year ago

On Mon, Nov 13, 2023 at 05:29:28PM +0100, Thomas Huth wrote:
> Let's use more inclusive language here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qapi/pragma.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/pragma.json b/qapi/pragma.json
> index 7f810b0e97..0aa4eeddd3 100644
> --- a/qapi/pragma.json
> +++ b/qapi/pragma.json
> @@ -3,8 +3,8 @@
>  
>  { 'pragma': { 'doc-required': true } }
>  
> -# Whitelists to permit QAPI rule violations; think twice before you
> -# add to them!
> +# Entries in these lists are allowed to violate the QAPI rules (for
> +# historical reasons); think twice before you add to them!
>  { 'pragma': {
>      # Command names containing '_'
>      'command-name-exceptions': [
> -- 
> 2.41.0
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org