[PATCH v2 0/2] s390x/pci: small set of fixes

Matthew Rosato posted 2 patches 2 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231110175108.465851-1-mjrosato@linux.ibm.com
Maintainers: Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Thomas Huth <thuth@redhat.com>
hw/s390x/s390-pci-vfio.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH v2 0/2] s390x/pci: small set of fixes
Posted by Matthew Rosato 2 years ago
The following set of changes are associated with issues exposed by testing
of the 'vfio: Adopt iommufd' series.

The first patch fixes an existing assumption that a vfio device will always
have a group fd (which is no longer true if cdev is used, which can only
happen once the iommufd backend is used).  This patch really only needs to
go into 8.2 if the 'vfio: Adopt iommufd' series does (but would be fine to 
go into 8.2 without it too).

The second patch fixes an issue where we do not detect that a vfio DMA limit
was never read from vfio.  This is actually an existing bug as it's possible
for an older host kernel to be missing this support today; so ideally this one
should be targeted for 8.2 regardless. 

Changes for v2:
- minor style changes (Phil, Thomas)

Matthew Rosato (2):
  s390x/pci: bypass vfio DMA counting when using cdev
  s390x/pci: only limit DMA aperture if vfio DMA limit reported

 hw/s390x/s390-pci-vfio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.41.0
Re: [PATCH v2 0/2] s390x/pci: small set of fixes
Posted by Eric Farman 2 years ago
On Fri, 2023-11-10 at 12:51 -0500, Matthew Rosato wrote:
> The following set of changes are associated with issues exposed by
> testing
> of the 'vfio: Adopt iommufd' series.

...snip...

> Matthew Rosato (2):
>   s390x/pci: bypass vfio DMA counting when using cdev
>   s390x/pci: only limit DMA aperture if vfio DMA limit reported
> 
>  hw/s390x/s390-pci-vfio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Apologies for missing v1 while I was out, but FWIW, for the series:

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Re: [PATCH v2 0/2] s390x/pci: small set of fixes
Posted by Thomas Huth 2 years ago
On 10/11/2023 18.51, Matthew Rosato wrote:
> The following set of changes are associated with issues exposed by testing
> of the 'vfio: Adopt iommufd' series.
> 
> The first patch fixes an existing assumption that a vfio device will always
> have a group fd (which is no longer true if cdev is used, which can only
> happen once the iommufd backend is used).  This patch really only needs to
> go into 8.2 if the 'vfio: Adopt iommufd' series does (but would be fine to
> go into 8.2 without it too).
> 
> The second patch fixes an issue where we do not detect that a vfio DMA limit
> was never read from vfio.  This is actually an existing bug as it's possible
> for an older host kernel to be missing this support today; so ideally this one
> should be targeted for 8.2 regardless.
> 
> Changes for v2:
> - minor style changes (Phil, Thomas)
> 
> Matthew Rosato (2):
>    s390x/pci: bypass vfio DMA counting when using cdev
>    s390x/pci: only limit DMA aperture if vfio DMA limit reported
> 
>   hw/s390x/s390-pci-vfio.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

Thank you, queued them now!

  Thomas