[v5] vfio: Adopt iommufd

[PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines

Posted by Zhenzhong Duan 1 year ago

From: Cédric Le Goater <clg@redhat.com>

Signed-off-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 hw/s390x/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
index 4c068d7960..26ad104485 100644
--- a/hw/s390x/Kconfig
+++ b/hw/s390x/Kconfig
@@ -6,6 +6,7 @@ config S390_CCW_VIRTIO
     imply VFIO_CCW
     imply WDT_DIAG288
     imply PCIE_DEVICES
+    imply IOMMUFD
     select PCI_EXPRESS
     select S390_FLIC
     select S390_FLIC_KVM if KVM
-- 
2.34.1

Re: [PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines

Posted by Matthew Rosato 1 year ago

On 11/9/23 6:45 AM, Zhenzhong Duan wrote:
> From: Cédric Le Goater <clg@redhat.com>
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>  hw/s390x/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
> index 4c068d7960..26ad104485 100644
> --- a/hw/s390x/Kconfig
> +++ b/hw/s390x/Kconfig
> @@ -6,6 +6,7 @@ config S390_CCW_VIRTIO
>      imply VFIO_CCW
>      imply WDT_DIAG288
>      imply PCIE_DEVICES
> +    imply IOMMUFD
>      select PCI_EXPRESS
>      select S390_FLIC
>      select S390_FLIC_KVM if KVM

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

I also ran tests against vfio-pci (mlx, ism, nvme), vfio-ap and vfio-ccw on s390x with an iommufd-enabled host kernel + this series.  Testing included having qemu open both fds, passing in one fd and letting qemu open the other, and passing in both fds.

Re: [PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines

Posted by Cédric Le Goater 1 year ago

On 11/10/23 00:00, Matthew Rosato wrote:
> On 11/9/23 6:45 AM, Zhenzhong Duan wrote:
>> From: Cédric Le Goater <clg@redhat.com>
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> ---
>>   hw/s390x/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
>> index 4c068d7960..26ad104485 100644
>> --- a/hw/s390x/Kconfig
>> +++ b/hw/s390x/Kconfig
>> @@ -6,6 +6,7 @@ config S390_CCW_VIRTIO
>>       imply VFIO_CCW
>>       imply WDT_DIAG288
>>       imply PCIE_DEVICES
>> +    imply IOMMUFD
>>       select PCI_EXPRESS
>>       select S390_FLIC
>>       select S390_FLIC_KVM if KVM
> 
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> 
> I also ran tests against vfio-pci (mlx, ism, nvme), vfio-ap and vfio-ccw on s390x with an iommufd-enabled host kernel + this series.  Testing included having qemu open both fds, passing in one fd and letting qemu open the other, and passing in both fds.

Thanks !

C.

RE: [PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines

Posted by Duan, Zhenzhong 1 year ago


>-----Original Message-----
>From: Matthew Rosato <mjrosato@linux.ibm.com>
>Sent: Friday, November 10, 2023 7:00 AM
>Subject: Re: [PATCH v5 19/20] kconfig: Activate IOMMUFD for s390x machines
>
>On 11/9/23 6:45 AM, Zhenzhong Duan wrote:
>> From: Cédric Le Goater <clg@redhat.com>
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> ---
>>  hw/s390x/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
>> index 4c068d7960..26ad104485 100644
>> --- a/hw/s390x/Kconfig
>> +++ b/hw/s390x/Kconfig
>> @@ -6,6 +6,7 @@ config S390_CCW_VIRTIO
>>      imply VFIO_CCW
>>      imply WDT_DIAG288
>>      imply PCIE_DEVICES
>> +    imply IOMMUFD
>>      select PCI_EXPRESS
>>      select S390_FLIC
>>      select S390_FLIC_KVM if KVM
>
>Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
>
>I also ran tests against vfio-pci (mlx, ism, nvme), vfio-ap and vfio-ccw on s390x
>with an iommufd-enabled host kernel + this series.  Testing included having qemu
>open both fds, passing in one fd and letting qemu open the other, and passing in
>both fds.

Thanks Matthew!

BRs.
Zhenzhong