[PATCH 22/22] Revert "tests/tcg/nios2: Re-enable linux-user tests"

Alex Bennée posted 22 patches 1 year ago
Maintainers: Laurent Vivier <laurent@vivier.eu>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>
[PATCH 22/22] Revert "tests/tcg/nios2: Re-enable linux-user tests"
Posted by Alex Bennée 1 year ago
nios2 signal tests are broken again:

  retry.py -n 10 -c -- ./qemu-nios2 ./tests/tcg/nios2-linux-user/signals
  Results summary:
  0: 8 times (80.00%), avg time 2.254 (0.00 varience/0.00 deviation)
  -11: 2 times (20.00%), avg time 0.253 (0.00 varience/0.00 deviation)
  Ran command 10 times, 8 passes

This wasn't picked up by CI as we don't have a docker container that
can build QEMU with the nios2 compiler. I don't have to bisect the
breakage and the target is orphaned anyway so take the easy route and
revert it.

This reverts commit 20e7524ff9f0cab4c9a0306014d6f3d7b467ae1e.

Cc: Chris Wulff <crwulff@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/tcg/nios2/Makefile.target | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 tests/tcg/nios2/Makefile.target

diff --git a/tests/tcg/nios2/Makefile.target b/tests/tcg/nios2/Makefile.target
new file mode 100644
index 0000000000..b38e2352b7
--- /dev/null
+++ b/tests/tcg/nios2/Makefile.target
@@ -0,0 +1,11 @@
+# nios2 specific test tweaks
+
+# Currently nios2 signal handling is broken
+run-signals: signals
+	$(call skip-test, $<, "BROKEN")
+run-plugin-signals-with-%:
+	$(call skip-test, $<, "BROKEN")
+run-linux-test: linux-test
+	$(call skip-test, $<, "BROKEN")
+run-plugin-linux-test-with-%:
+	$(call skip-test, $<, "BROKEN")
-- 
2.39.2


Re: [PATCH 22/22] Revert "tests/tcg/nios2: Re-enable linux-user tests"
Posted by Richard Henderson 1 year ago
On 11/6/23 10:51, Alex Bennée wrote:
> nios2 signal tests are broken again:
> 
>    retry.py -n 10 -c -- ./qemu-nios2 ./tests/tcg/nios2-linux-user/signals
>    Results summary:
>    0: 8 times (80.00%), avg time 2.254 (0.00 varience/0.00 deviation)
>    -11: 2 times (20.00%), avg time 0.253 (0.00 varience/0.00 deviation)
>    Ran command 10 times, 8 passes
> 
> This wasn't picked up by CI as we don't have a docker container that
> can build QEMU with the nios2 compiler. I don't have to bisect the
> breakage and the target is orphaned anyway so take the easy route and
> revert it.
> 
> This reverts commit 20e7524ff9f0cab4c9a0306014d6f3d7b467ae1e.
> 
> Cc: Chris Wulff <crwulff@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Ug.  It's definitely time to deprecate prior to removal.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~