target/arm: Fix various FEAT_MOPS bugs

[PATCH 0/3] target/arm: Fix various FEAT_MOPS bugs

Peter Maydell posted 3 patches 1 year ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231030174000.3792225-1-peter.maydell@linaro.org

Maintainers: Laurent Vivier <laurent@vivier.eu>, Peter Maydell <peter.maydell@linaro.org>

linux-user/loader.h         |  2 +-
linux-user/elfload.c        |  8 ++++----
target/arm/cpu.c            |  2 ++
target/arm/tcg/helper-a64.c | 15 ++++++++++++---
4 files changed, 19 insertions(+), 8 deletions(-)

Expand all Fold all

[PATCH 0/3] target/arm: Fix various FEAT_MOPS bugs

Posted by Peter Maydell 1 year ago

This patchset fixes some bugs in FEAT_MOPS that were encountered
by somebody trying to use it in qemu user-mode:
 * we forgot to set the SCTLR bit in CPU reset, so all the
   insns UNDEF
 * we weren't reporting the hwcap bit because of a uint32_t
   vs uint64_t mixup
 * we didn't handle the case of SET* with Xs == XZR correctly

This set of patches fix these issues.

thanks
-- PMM

Peter Maydell (3):
  target/arm: Enable FEAT_MOPS insns in user-mode emulation
  linux-user: Report AArch64 hwcap2 fields above bit 31
  target/arm: Make FEAT_MOPS SET* insns handle Xs == XZR correctly

 linux-user/loader.h         |  2 +-
 linux-user/elfload.c        |  8 ++++----
 target/arm/cpu.c            |  2 ++
 target/arm/tcg/helper-a64.c | 15 ++++++++++++---
 4 files changed, 19 insertions(+), 8 deletions(-)

-- 
2.34.1

Re: [PATCH 0/3] target/arm: Fix various FEAT_MOPS bugs

Posted by Richard Henderson 1 year ago

On 10/30/23 10:39, Peter Maydell wrote:
> This patchset fixes some bugs in FEAT_MOPS that were encountered
> by somebody trying to use it in qemu user-mode:
>   * we forgot to set the SCTLR bit in CPU reset, so all the
>     insns UNDEF
>   * we weren't reporting the hwcap bit because of a uint32_t
>     vs uint64_t mixup
>   * we didn't handle the case of SET* with Xs == XZR correctly
> 
> This set of patches fix these issues.
> 
> thanks
> -- PMM
> 
> Peter Maydell (3):
>    target/arm: Enable FEAT_MOPS insns in user-mode emulation
>    linux-user: Report AArch64 hwcap2 fields above bit 31
>    target/arm: Make FEAT_MOPS SET* insns handle Xs == XZR correctly

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~