[v2] tcg: Introduce TCG_COND_TST{EQ,NE}

[PATCH v2 19/35] tcg/sparc64: Implement tcg_out_extrl_i64_i32

Posted by Richard Henderson 1 year, 1 month ago

Build fix for missing symbol.

Cc: qemu-stable@nongnu.org
Fixes: b8b94ac6753 ("tcg: Split out tcg_out_extrl_i64_i32")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/sparc64/tcg-target.c.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc
index 386f51f29e..ac86b92b75 100644
--- a/tcg/sparc64/tcg-target.c.inc
+++ b/tcg/sparc64/tcg-target.c.inc
@@ -530,6 +530,11 @@ static void tcg_out_extu_i32_i64(TCGContext *s, TCGReg rd, TCGReg rs)
     tcg_out_ext32u(s, rd, rs);
 }
 
+static void tcg_out_extrl_i64_i32(TCGContext *s, TCGReg rd, TCGReg rs)
+{
+    tcg_out_ext32u(s, rd, rs);
+}
+
 static bool tcg_out_xchg(TCGContext *s, TCGType type, TCGReg r1, TCGReg r2)
 {
     return false;
-- 
2.34.1

Re: [PATCH v2 19/35] tcg/sparc64: Implement tcg_out_extrl_i64_i32

Posted by Philippe Mathieu-Daudé 1 year ago

On 28/10/23 21:45, Richard Henderson wrote:
> Build fix for missing symbol.
> 
> Cc: qemu-stable@nongnu.org
> Fixes: b8b94ac6753 ("tcg: Split out tcg_out_extrl_i64_i32")

Commit b8b94ac6753 looks correct, don't we want:
Fixes: dad2f2f5af ("tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32")
?

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/sparc64/tcg-target.c.inc | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc
> index 386f51f29e..ac86b92b75 100644
> --- a/tcg/sparc64/tcg-target.c.inc
> +++ b/tcg/sparc64/tcg-target.c.inc
> @@ -530,6 +530,11 @@ static void tcg_out_extu_i32_i64(TCGContext *s, TCGReg rd, TCGReg rs)
>       tcg_out_ext32u(s, rd, rs);
>   }
>   
> +static void tcg_out_extrl_i64_i32(TCGContext *s, TCGReg rd, TCGReg rs)
> +{
> +    tcg_out_ext32u(s, rd, rs);
> +}
> +
>   static bool tcg_out_xchg(TCGContext *s, TCGType type, TCGReg r1, TCGReg r2)
>   {
>       return false;

Re: [PATCH v2 19/35] tcg/sparc64: Implement tcg_out_extrl_i64_i32

Posted by Richard Henderson 1 year ago

On 11/6/23 07:05, Philippe Mathieu-Daudé wrote:
> On 28/10/23 21:45, Richard Henderson wrote:
>> Build fix for missing symbol.
>>
>> Cc: qemu-stable@nongnu.org
>> Fixes: b8b94ac6753 ("tcg: Split out tcg_out_extrl_i64_i32")
> 
> Commit b8b94ac6753 looks correct, don't we want:
> Fixes: dad2f2f5af ("tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32")
> ?

You're right -- I thought the TCG_TARGET_HAS_extr_i64_i32 cleanup came first, but not so.


r~