[PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module

Nabih Estefan posted 11 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231027175532.3601297-1-nabihestefan@google.com
Maintainers: Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, Peter Maydell <peter.maydell@linaro.org>, Jason Wang <jasowang@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
There is a newer version of this series
docs/system/arm/nuvoton.rst         |   2 +
hw/arm/npcm7xx.c                    |  53 +-
hw/misc/meson.build                 |   1 +
hw/misc/npcm7xx_pci_mbox.c          | 324 ++++++++++
hw/misc/trace-events                |   5 +
hw/net/meson.build                  |   2 +-
hw/net/npcm_gmac.c                  | 942 ++++++++++++++++++++++++++++
hw/net/trace-events                 |  19 +
include/hw/arm/npcm7xx.h            |   4 +
include/hw/misc/npcm7xx_pci_mbox.h  |  81 +++
include/hw/net/npcm_gmac.h          | 340 ++++++++++
tests/qtest/meson.build             |   8 +-
tests/qtest/npcm7xx_pci_mbox-test.c | 238 +++++++
tests/qtest/npcm_gmac-test.c        | 341 ++++++++++
14 files changed, 2351 insertions(+), 9 deletions(-)
create mode 100644 hw/misc/npcm7xx_pci_mbox.c
create mode 100644 hw/net/npcm_gmac.c
create mode 100644 include/hw/misc/npcm7xx_pci_mbox.h
create mode 100644 include/hw/net/npcm_gmac.h
create mode 100644 tests/qtest/npcm7xx_pci_mbox-test.c
create mode 100644 tests/qtest/npcm_gmac-test.c
[PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module
Posted by Nabih Estefan 1 year, 1 month ago
From: Nabih Estefan Diaz <nabihestefan@google.com>

[Changes since v4]
Added Signed-off-by tag and fixed patch 4 commit message as suggested by
Peter Maydell (peter.maydell@linaro.org)

[Changes since v3]
Fixed comments from Hao Wu (wuhaotsh@google.com)

[Changes since v2]
Fixed bugs related to the RC functionality of the GMAC. Added and
squashed patches related to that.

[Changes since v1]
Fixed some errors in formatting.
Fixed a merge error that I didn't see in v1.
Removed Nuvoton 8xx references since that is a separate patch set.

[Original Cover]
Creates NPI Mailbox Module with data verification for read and write (internal and external),
wiring to the Nuvoton SoC, and QTests.

Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors
and registers. Also includes QTests for the different functionalities.

Hao Wu (5):
  hw/misc: Add Nuvoton's PCI Mailbox Module
  hw/arm: Add PCI mailbox module to Nuvoton SoC
  hw/misc: Add qtest for NPCM7xx PCI Mailbox
  hw/net: Add NPCMXXX GMAC device
  hw/arm: Add GMAC devices to NPCM7XX SoC

Nabih Estefan Diaz (6):
  tests/qtest: Creating qtest for GMAC Module
  include/hw/net: Implemented Classes and Masks for GMAC Descriptors
  hw/net: General GMAC Implementation
  hw/net: GMAC Rx Implementation
  hw/net: GMAC Tx Implementation
  tests/qtest: Adding PCS Module test to GMAC Qtest

 docs/system/arm/nuvoton.rst         |   2 +
 hw/arm/npcm7xx.c                    |  53 +-
 hw/misc/meson.build                 |   1 +
 hw/misc/npcm7xx_pci_mbox.c          | 324 ++++++++++
 hw/misc/trace-events                |   5 +
 hw/net/meson.build                  |   2 +-
 hw/net/npcm_gmac.c                  | 942 ++++++++++++++++++++++++++++
 hw/net/trace-events                 |  19 +
 include/hw/arm/npcm7xx.h            |   4 +
 include/hw/misc/npcm7xx_pci_mbox.h  |  81 +++
 include/hw/net/npcm_gmac.h          | 340 ++++++++++
 tests/qtest/meson.build             |   8 +-
 tests/qtest/npcm7xx_pci_mbox-test.c | 238 +++++++
 tests/qtest/npcm_gmac-test.c        | 341 ++++++++++
 14 files changed, 2351 insertions(+), 9 deletions(-)
 create mode 100644 hw/misc/npcm7xx_pci_mbox.c
 create mode 100644 hw/net/npcm_gmac.c
 create mode 100644 include/hw/misc/npcm7xx_pci_mbox.h
 create mode 100644 include/hw/net/npcm_gmac.h
 create mode 100644 tests/qtest/npcm7xx_pci_mbox-test.c
 create mode 100644 tests/qtest/npcm_gmac-test.c

-- 
2.42.0.820.g83a721a137-goog
Re: [PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module
Posted by Nabih Estefan 11 months, 3 weeks ago
Hello,

Since all patches for this change have been reviewed, is it possible
to apply it to the current branch so it can be fully upstreamed?

Thank you!
Nabih Estefan (he/him) |  Software Engineer |
nabihestefan@google.com |  857-308-9574

Nabih Estefan (he/him) |  Software Engineer |
nabihestefan@google.com |  857-308-9574



On Fri, Oct 27, 2023 at 10:55 AM Nabih Estefan <nabihestefan@google.com> wrote:
>
> From: Nabih Estefan Diaz <nabihestefan@google.com>
>
> [Changes since v4]
> Added Signed-off-by tag and fixed patch 4 commit message as suggested by
> Peter Maydell (peter.maydell@linaro.org)
>
> [Changes since v3]
> Fixed comments from Hao Wu (wuhaotsh@google.com)
>
> [Changes since v2]
> Fixed bugs related to the RC functionality of the GMAC. Added and
> squashed patches related to that.
>
> [Changes since v1]
> Fixed some errors in formatting.
> Fixed a merge error that I didn't see in v1.
> Removed Nuvoton 8xx references since that is a separate patch set.
>
> [Original Cover]
> Creates NPI Mailbox Module with data verification for read and write (internal and external),
> wiring to the Nuvoton SoC, and QTests.
>
> Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors
> and registers. Also includes QTests for the different functionalities.
>
> Hao Wu (5):
>   hw/misc: Add Nuvoton's PCI Mailbox Module
>   hw/arm: Add PCI mailbox module to Nuvoton SoC
>   hw/misc: Add qtest for NPCM7xx PCI Mailbox
>   hw/net: Add NPCMXXX GMAC device
>   hw/arm: Add GMAC devices to NPCM7XX SoC
>
> Nabih Estefan Diaz (6):
>   tests/qtest: Creating qtest for GMAC Module
>   include/hw/net: Implemented Classes and Masks for GMAC Descriptors
>   hw/net: General GMAC Implementation
>   hw/net: GMAC Rx Implementation
>   hw/net: GMAC Tx Implementation
>   tests/qtest: Adding PCS Module test to GMAC Qtest
>
>  docs/system/arm/nuvoton.rst         |   2 +
>  hw/arm/npcm7xx.c                    |  53 +-
>  hw/misc/meson.build                 |   1 +
>  hw/misc/npcm7xx_pci_mbox.c          | 324 ++++++++++
>  hw/misc/trace-events                |   5 +
>  hw/net/meson.build                  |   2 +-
>  hw/net/npcm_gmac.c                  | 942 ++++++++++++++++++++++++++++
>  hw/net/trace-events                 |  19 +
>  include/hw/arm/npcm7xx.h            |   4 +
>  include/hw/misc/npcm7xx_pci_mbox.h  |  81 +++
>  include/hw/net/npcm_gmac.h          | 340 ++++++++++
>  tests/qtest/meson.build             |   8 +-
>  tests/qtest/npcm7xx_pci_mbox-test.c | 238 +++++++
>  tests/qtest/npcm_gmac-test.c        | 341 ++++++++++
>  14 files changed, 2351 insertions(+), 9 deletions(-)
>  create mode 100644 hw/misc/npcm7xx_pci_mbox.c
>  create mode 100644 hw/net/npcm_gmac.c
>  create mode 100644 include/hw/misc/npcm7xx_pci_mbox.h
>  create mode 100644 include/hw/net/npcm_gmac.h
>  create mode 100644 tests/qtest/npcm7xx_pci_mbox-test.c
>  create mode 100644 tests/qtest/npcm_gmac-test.c
>
> --
> 2.42.0.820.g83a721a137-goog
>
Re: [PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module
Posted by Peter Maydell 11 months, 3 weeks ago
On Tue, 5 Dec 2023 at 17:54, Nabih Estefan <nabihestefan@google.com> wrote:
>
> Hello,
>
> Since all patches for this change have been reviewed, is it possible
> to apply it to the current branch so it can be fully upstreamed?

Thanks for the ping; this is on my list of patchseries to look
at, but it won't go upstream until we unfreeze after the 8.2
release (which will be a couple of weeks yet).

-- PMM