1. Patchew
  2. QEMU
  3. View series

[PATCH 0/1] Enable -Wshadow=local

Markus Armbruster posted 1 patch 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231026053115.2066744-1-armbru@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>
meson.build | 1 +
1 file changed, 1 insertion(+)
[PATCH 0/1] Enable -Wshadow=local
Posted by Markus Armbruster 1 year, 1 month ago 
Requires Brian's pull request and two patches from Thomas to compile:

    [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
    [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
    [PATCH v2] migration/ram: Fix compilation with -Wshadow=local

Stefan, the PR was posted a week ago; anything blocking it?

Warner, I believe not waiting for your cleanup of bsd-user is fine.
Please holler if it isn't.

Based-on: <20231019021733.2258592-1-bcain@quicinc.com>
Based-on: <20231023175038.111607-1-thuth@redhat.com>
Based-on: <20231024092220.55305-1-thuth@redhat.com>

Markus Armbruster (1):
  meson: Enable -Wshadow=local

 meson.build | 1 +
 1 file changed, 1 insertion(+)

-- 
2.41.0
Re: [PATCH 0/1] Enable -Wshadow=local
Posted by Stefan Hajnoczi 1 year, 1 month ago 
On Thu, 26 Oct 2023 at 14:32, Markus Armbruster <armbru@redhat.com> wrote:
>
> Requires Brian's pull request and two patches from Thomas to compile:
>
>     [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
>     [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
>     [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
>
> Stefan, the PR was posted a week ago; anything blocking it?

It's not in a pull request, so I won't see it. I don't have tooling
that can spot individual patch series that need to go into
qemu.git/master, so I rely on being emailed about them.

Would you like me to merge this patch series into qemu.git/master?

Stefan

> Warner, I believe not waiting for your cleanup of bsd-user is fine.
> Please holler if it isn't.
>
> Based-on: <20231019021733.2258592-1-bcain@quicinc.com>
> Based-on: <20231023175038.111607-1-thuth@redhat.com>
> Based-on: <20231024092220.55305-1-thuth@redhat.com>
>
> Markus Armbruster (1):
>   meson: Enable -Wshadow=local
>
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> --
> 2.41.0
>
>
Re: [PATCH 0/1] Enable -Wshadow=local
Posted by Markus Armbruster 1 year, 1 month ago 
Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Thu, 26 Oct 2023 at 14:32, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Requires Brian's pull request and two patches from Thomas to compile:
>>
>>     [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
>>     [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
>>     [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
>>
>> Stefan, the PR was posted a week ago; anything blocking it?
>
> It's not in a pull request, so I won't see it. I don't have tooling
> that can spot individual patch series that need to go into
> qemu.git/master, so I rely on being emailed about them.

I'm inquiring about this one:

    https://lore.kernel.org/qemu-devel/20231019021733.2258592-1-bcain@quicinc.com/

Looks like a PR to me.

> Would you like me to merge this patch series into qemu.git/master?

Yes, I'd like you merge Brian's PR I linked to.

[...]
Re: [PATCH 0/1] Enable -Wshadow=local
Posted by Stefan Hajnoczi 1 year ago 
On Fri, 27 Oct 2023 at 13:42, Markus Armbruster <armbru@redhat.com> wrote:
>
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
> > On Thu, 26 Oct 2023 at 14:32, Markus Armbruster <armbru@redhat.com> wrote:
> >>
> >> Requires Brian's pull request and two patches from Thomas to compile:
> >>
> >>     [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
> >>     [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
> >>     [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
> >>
> >> Stefan, the PR was posted a week ago; anything blocking it?
> >
> > It's not in a pull request, so I won't see it. I don't have tooling
> > that can spot individual patch series that need to go into
> > qemu.git/master, so I rely on being emailed about them.
>
> I'm inquiring about this one:
>
>     https://lore.kernel.org/qemu-devel/20231019021733.2258592-1-bcain@quicinc.com/
>
> Looks like a PR to me.
>
> > Would you like me to merge this patch series into qemu.git/master?
>
> Yes, I'd like you merge Brian's PR I linked to.

Sorry, I missed that because of a bug in the 'patches' tool that I
use. The PR is running through CI now.

I've fixed the 'patches' tool to decode emails with
Content-Transfer-Encoding: base64 now:
https://github.com/stefanha/patches/commit/35531a8668f551356c019f68670fcb154535ccd3

Stefan
RE: [PATCH 0/1] Enable -Wshadow=local
Posted by Brian Cain 1 year, 1 month ago 

> -----Original Message-----
> From: Stefan Hajnoczi <stefanha@gmail.com>
> Sent: Thursday, October 26, 2023 7:52 PM
> To: Markus Armbruster <armbru@redhat.com>
> Cc: qemu-devel@nongnu.org; pbonzini@redhat.com;
> marcandre.lureau@redhat.com; berrange@redhat.com; thuth@redhat.com;
> philmd@linaro.org; Brian Cain <bcain@quicinc.com>; imp@bsdimp.com;
> stefanha@redhat.com
> Subject: Re: [PATCH 0/1] Enable -Wshadow=local
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> On Thu, 26 Oct 2023 at 14:32, Markus Armbruster <armbru@redhat.com>
> wrote:
> >
> > Requires Brian's pull request and two patches from Thomas to compile:
> >
> >     [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
> >     [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
> >     [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
> >
> > Stefan, the PR was posted a week ago; anything blocking it?
> 
> It's not in a pull request, so I won't see it. I don't have tooling
> that can spot individual patch series that need to go into
> qemu.git/master, so I rely on being emailed about them.

My mistake -- I thought I had emailed you.  But I see now that I likely used the wrong email address.

> 
> Would you like me to merge this patch series into qemu.git/master?
> 
> Stefan
> 
> > Warner, I believe not waiting for your cleanup of bsd-user is fine.
> > Please holler if it isn't.
> >
> > Based-on: <20231019021733.2258592-1-bcain@quicinc.com>
> > Based-on: <20231023175038.111607-1-thuth@redhat.com>
> > Based-on: <20231024092220.55305-1-thuth@redhat.com>
> >
> > Markus Armbruster (1):
> >   meson: Enable -Wshadow=local
> >
> >  meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > --
> > 2.41.0
> >
> >
Re: [PATCH 0/1] Enable -Wshadow=local
Posted by Warner Losh 1 year, 1 month ago 
On Wed, Oct 25, 2023, 11:31 PM Markus Armbruster <armbru@redhat.com> wrote:

> Requires Brian's pull request and two patches from Thomas to compile:
>
>     [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes
>     [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local
>     [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
>
> Stefan, the PR was posted a week ago; anything blocking it?
>
> Warner, I believe not waiting for your cleanup of bsd-user is fine.
> Please holler if it isn't.
>

If it's not enabled by default for Clang, then sure. It's only one small
change at this point, but i was ill for a few weeks (much longer than i
thought I'd be) and am still catching up.

Warner

 <20231019021733.2258592-1-bcain@quicinc.com>

> Based-on: <20231023175038.111607-1-thuth@redhat.com>
> Based-on: <20231024092220.55305-1-thuth@redhat.com>
>
> Markus Armbruster (1):
>   meson: Enable -Wshadow=local
>
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)
>
> --
> 2.41.0
>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.