[v1] hw/m68k: Strengthen QOM/SysBus API uses

[PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses

Philippe Mathieu-Daudé posted 6 patches 2 years, 1 month ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231020150627.56893-1-philmd@linaro.org

Maintainers: Laurent Vivier <laurent@vivier.eu>, Thomas Huth <huth@tuxfamily.org>

There is a newer version of this series

include/hw/intc/m68k_irqc.h |  1 +
hw/intc/m68k_irqc.c         | 10 +++++++++-
hw/m68k/an5206.c            |  2 ++
hw/m68k/mcf5206.c           |  9 ++++++++-
hw/m68k/mcf_intc.c          | 21 ++++++++++++++-------
hw/m68k/next-cube.c         |  9 ++-------
hw/m68k/virt.c              |  9 ++++-----
7 files changed, 40 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses

Posted by Philippe Mathieu-Daudé 2 years, 1 month ago

Avoid QOM objects poking at each other internals:
- Pass "link" properties
- Access MMIO via SysBus API
- Simplify using sysbus_create_simple()

Philippe Mathieu-Daudé (6):
  hw/m68k/irqc: Pass CPU using QOM link property
  hw/m68k/mcf5206: Pass CPU using QOM link property
  hw/m68k/mcf_intc: Expose MMIO region via SysBus API
  hw/m68k/mcf_intc: Pass CPU using QOM link property
  hw/m68k/next-cube: Do not open-code sysbus_create_simple()
  hw/m68k/virt: Do not open-code sysbus_create_simple()

 include/hw/intc/m68k_irqc.h |  1 +
 hw/intc/m68k_irqc.c         | 10 +++++++++-
 hw/m68k/an5206.c            |  2 ++
 hw/m68k/mcf5206.c           |  9 ++++++++-
 hw/m68k/mcf_intc.c          | 21 ++++++++++++++-------
 hw/m68k/next-cube.c         |  9 ++-------
 hw/m68k/virt.c              |  9 ++++-----
 7 files changed, 40 insertions(+), 21 deletions(-)

-- 
2.41.0

Re: [PATCH 0/6] hw/m68k: Strengthen QOM/SysBus API uses

Posted by Richard Henderson 2 years, 1 month ago

On 10/20/23 08:06, Philippe Mathieu-Daudé wrote:
> Avoid QOM objects poking at each other internals:
> - Pass "link" properties
> - Access MMIO via SysBus API
> - Simplify using sysbus_create_simple()
> 
> Philippe Mathieu-Daudé (6):
>    hw/m68k/irqc: Pass CPU using QOM link property
>    hw/m68k/mcf5206: Pass CPU using QOM link property
>    hw/m68k/mcf_intc: Expose MMIO region via SysBus API
>    hw/m68k/mcf_intc: Pass CPU using QOM link property
>    hw/m68k/next-cube: Do not open-code sysbus_create_simple()
>    hw/m68k/virt: Do not open-code sysbus_create_simple()

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~