[v3] hw/arm/pxa2xx: SysBus/QDev fixes

[PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Missing review: 6-9

Hi,

Extracted from a bigger series which enforce QDev state machine
(qdev instance must be realized before external API is used on
it).

While here, pxa2xx i2c/intc devices received some qdev fondness.

Since v3:
- Added Thomas R-b tags

Since v2:
- Fixed i2c_init_bus() call in pxa2xx_i2c_init() (new patch)

Philippe Mathieu-Daudé (9):
  hw/sd/pxa2xx: Realize sysbus device before accessing it
  hw/sd/pxa2xx: Do not open-code sysbus_create_simple()
  hw/pcmcia/pxa2xx: Realize sysbus device before accessing it
  hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple()
  hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()
  hw/intc/pxa2xx: Convert to Resettable interface
  hw/intc/pxa2xx: Pass CPU reference using QOM link property
  hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init()
  hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it

 include/hw/arm/pxa.h |  2 --
 hw/arm/pxa2xx.c      | 17 +++++++++++------
 hw/arm/pxa2xx_pic.c  | 38 +++++++++++++++++++++++++++++---------
 hw/pcmcia/pxa2xx.c   | 15 ---------------
 hw/sd/pxa2xx_mmci.c  |  7 +------
 5 files changed, 41 insertions(+), 38 deletions(-)

-- 
2.41.0

Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes

Posted by Peter Maydell 1 year, 1 month ago

On Fri, 20 Oct 2023 at 14:03, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Missing review: 6-9
>
> Hi,
>
> Extracted from a bigger series which enforce QDev state machine
> (qdev instance must be realized before external API is used on
> it).
>
> While here, pxa2xx i2c/intc devices received some qdev fondness.

Applied to target-arm.next, thanks.

-- PMM

Re: [PATCH v3 0/9] hw/arm/pxa2xx: SysBus/QDev fixes

Posted by Richard Henderson 1 year, 1 month ago

On 10/20/23 06:03, Philippe Mathieu-Daudé wrote:
> Missing review: 6-9
> 
> Hi,
> 
> Extracted from a bigger series which enforce QDev state machine
> (qdev instance must be realized before external API is used on
> it).
> 
> While here, pxa2xx i2c/intc devices received some qdev fondness.
> 
> Since v3:
> - Added Thomas R-b tags
> 
> Since v2:
> - Fixed i2c_init_bus() call in pxa2xx_i2c_init() (new patch)
> 
> Philippe Mathieu-Daudé (9):
>    hw/sd/pxa2xx: Realize sysbus device before accessing it
>    hw/sd/pxa2xx: Do not open-code sysbus_create_simple()
>    hw/pcmcia/pxa2xx: Realize sysbus device before accessing it
>    hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple()
>    hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()
>    hw/intc/pxa2xx: Convert to Resettable interface
>    hw/intc/pxa2xx: Pass CPU reference using QOM link property
>    hw/intc/pxa2xx: Factor pxa2xx_pic_realize() out of pxa2xx_pic_init()
>    hw/arm/pxa2xx: Realize PXA2XX_I2C device before accessing it

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~