[v1] hw/s390x: Don't call register_savevm_live() during instance_init()

[PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

Thomas Huth posted 3 patches 2 years, 2 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231020125728.579747-1-thuth@redhat.com

Maintainers: Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>

There is a newer version of this series

hw/s390x/s390-skeys.c    | 35 ++++++--------------------
hw/s390x/s390-stattrib.c | 54 +++++++++++++++-------------------------
2 files changed, 28 insertions(+), 61 deletions(-)

Expand all Fold all

[PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

Posted by Thomas Huth 2 years, 2 months ago

We must not call register_savevm_live() during instance_init()
since instances can be created at any time, e.g. during introspection
of a device. We must register the savevm handler during realize()
instead. Fix it now in the s390x devices.

Thomas Huth (3):
  hw/s390x/s390-skeys: Don't call register_savevm_live() during
    instance_init()
  hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled"
    property
  hw/s390x/s390-stattrib: Don't call register_savevm_live() during
    instance_init()

 hw/s390x/s390-skeys.c    | 35 ++++++--------------------
 hw/s390x/s390-stattrib.c | 54 +++++++++++++++-------------------------
 2 files changed, 28 insertions(+), 61 deletions(-)

-- 
2.41.0

Re: [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

Posted by Eric Farman 2 years, 2 months ago

On Fri, 2023-10-20 at 14:57 +0200, Thomas Huth wrote:
> We must not call register_savevm_live() during instance_init()
> since instances can be created at any time, e.g. during introspection
> of a device. We must register the savevm handler during realize()
> instead. Fix it now in the s390x devices.
> 
> Thomas Huth (3):
>   hw/s390x/s390-skeys: Don't call register_savevm_live() during
>     instance_init()
>   hw/s390x/s390-stattrib: Simplify handling of the "migration-
> enabled"
>     property
>   hw/s390x/s390-stattrib: Don't call register_savevm_live() during
>     instance_init()
> 
>  hw/s390x/s390-skeys.c    | 35 ++++++--------------------
>  hw/s390x/s390-stattrib.c | 54 +++++++++++++++-----------------------
> --
>  2 files changed, 28 insertions(+), 61 deletions(-)

Man, this makes it a lot easier to read too. With the amended patch 3:

Reviewed-by: Eric Farman <farman@linux.ibm.com>

Re: [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()

Posted by David Hildenbrand 2 years, 2 months ago

On 20.10.23 14:57, Thomas Huth wrote:
> We must not call register_savevm_live() during instance_init()
> since instances can be created at any time, e.g. during introspection
> of a device. We must register the savevm handler during realize()
> instead. Fix it now in the s390x devices.
> 
> Thomas Huth (3):
>    hw/s390x/s390-skeys: Don't call register_savevm_live() during
>      instance_init()
>    hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled"
>      property
>    hw/s390x/s390-stattrib: Don't call register_savevm_live() during
>      instance_init()
> 
>   hw/s390x/s390-skeys.c    | 35 ++++++--------------------
>   hw/s390x/s390-stattrib.c | 54 +++++++++++++++-------------------------
>   2 files changed, 28 insertions(+), 61 deletions(-)
> 

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb