[v3] hw/audio/pcspk: Inline pcspk_init()

[PATCH v3 0/5] hw/audio/pcspk: Inline pcspk_init()

Philippe Mathieu-Daudé posted 5 patches 1 year, 1 month ago

Diff against v1 v2 v4
Download series mbox

Failed in applying to current master (apply log)

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Hervé Poussineau" <hpoussin@reactos.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>

There is a newer version of this series

include/hw/audio/pcspk.h | 10 ----------
include/hw/i386/pc.h     |  5 +++--
hw/i386/pc.c             | 17 +++++++++++++----
hw/i386/pc_piix.c        |  2 +-
hw/i386/pc_q35.c         |  2 +-
hw/isa/i82378.c          |  7 ++++++-
hw/mips/jazz.c           |  5 ++++-
7 files changed, 28 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH v3 0/5] hw/audio/pcspk: Inline pcspk_init()

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Since v2:
- Propagate error in hw/i386/

Philippe Mathieu-Daudé (5):
  hw/i386/pc: Pass Error** argument to pc_basic_device_init()
  hw/i386/pc: Propagate error if HPET device creation failed
  hw/i386/pc: Inline legacy pcspk_init() in pc_basic_device_init()
  hw/isa/i82378: Inline legacy pcspk_init()
  hw/mips/jazz: Inline and remove legacy pcspk_init()

 include/hw/audio/pcspk.h | 10 ----------
 include/hw/i386/pc.h     |  5 +++--
 hw/i386/pc.c             | 17 +++++++++++++----
 hw/i386/pc_piix.c        |  2 +-
 hw/i386/pc_q35.c         |  2 +-
 hw/isa/i82378.c          |  7 ++++++-
 hw/mips/jazz.c           |  5 ++++-
 7 files changed, 28 insertions(+), 20 deletions(-)

-- 
2.41.0

Re: [PATCH v3 0/5] hw/audio/pcspk: Inline pcspk_init()

Posted by Richard Henderson 1 year, 1 month ago

On 10/20/23 03:54, Philippe Mathieu-Daudé wrote:
> Since v2:
> - Propagate error in hw/i386/
> 
> Philippe Mathieu-Daudé (5):
>    hw/i386/pc: Pass Error** argument to pc_basic_device_init()
>    hw/i386/pc: Propagate error if HPET device creation failed
>    hw/i386/pc: Inline legacy pcspk_init() in pc_basic_device_init()
>    hw/isa/i82378: Inline legacy pcspk_init()
>    hw/mips/jazz: Inline and remove legacy pcspk_init()
> 
>   include/hw/audio/pcspk.h | 10 ----------
>   include/hw/i386/pc.h     |  5 +++--
>   hw/i386/pc.c             | 17 +++++++++++++----
>   hw/i386/pc_piix.c        |  2 +-
>   hw/i386/pc_q35.c         |  2 +-
>   hw/isa/i82378.c          |  7 ++++++-
>   hw/mips/jazz.c           |  5 ++++-
>   7 files changed, 28 insertions(+), 20 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~