[PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x

Thomas Huth posted 1 patch 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231018091239.164452-1-thuth@redhat.com
Maintainers: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Leonardo Bras <leobras@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
tests/qtest/migration-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x
Posted by Thomas Huth 1 year, 1 month ago
The analyze-migration.py script fails on s390x hosts:

 Traceback (most recent call last):
   File "scripts/analyze-migration.py", line 662, in <module>
     dump.read(dump_memory = args.memory)
   File "scripts/analyze-migration.py", line 596, in read
     classdesc = self.section_classes[section_key]
 KeyError: ('s390-storage_attributes', 0)

It obviously never has been adapted to s390x yet, so until this
has been done, disable this test on s390x.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/migration-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index e1c110537b..241b409857 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3034,7 +3034,9 @@ int main(int argc, char **argv)
 
     qtest_add_func("/migration/bad_dest", test_baddest);
 #ifndef _WIN32
-    qtest_add_func("/migration/analyze-script", test_analyze_script);
+    if (!g_str_equal(arch, "s390x")) {
+        qtest_add_func("/migration/analyze-script", test_analyze_script);
+    }
 #endif
     qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain);
     qtest_add_func("/migration/precopy/unix/xbzrle", test_precopy_unix_xbzrle);
-- 
2.41.0
Re: [PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x
Posted by Juan Quintela 1 year, 1 month ago
Thomas Huth <thuth@redhat.com> wrote:
> The analyze-migration.py script fails on s390x hosts:
>
>  Traceback (most recent call last):
>    File "scripts/analyze-migration.py", line 662, in <module>
>      dump.read(dump_memory = args.memory)
>    File "scripts/analyze-migration.py", line 596, in read
>      classdesc = self.section_classes[section_key]
>  KeyError: ('s390-storage_attributes', 0)
>
> It obviously never has been adapted to s390x yet, so until this
> has been done, disable this test on s390x.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>


Reviewed-by: Juan Quintela <quintela@redhat.com>