[v1] target/hppa: Add emulation of a C3700 HP-PARISC workstation

[PATCH 06/12] tulip: Use the HP PCI vendor ID instead of number

Posted by deller@kernel.org 1 year, 1 month ago

From: Helge Deller <deller@gmx.de>

Signed-off-by: Helge Deller <deller@gmx.de>
---
 hw/net/tulip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index 915e5fb595..11d866e431 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -1020,7 +1020,7 @@ static void tulip_class_init(ObjectClass *klass, void *data)
     k->exit = pci_tulip_exit;
     k->vendor_id = PCI_VENDOR_ID_DEC;
     k->device_id = PCI_DEVICE_ID_DEC_21143;
-    k->subsystem_vendor_id = 0x103c;
+    k->subsystem_vendor_id = PCI_VENDOR_ID_HP;
     k->subsystem_id = 0x104f;
     k->class_id = PCI_CLASS_NETWORK_ETHERNET;
     dc->vmsd = &vmstate_pci_tulip;
-- 
2.41.0

Re: [PATCH 06/12] tulip: Use the HP PCI vendor ID instead of number

Posted by BALATON Zoltan 1 year, 1 month ago

On Sat, 14 Oct 2023, deller@kernel.org wrote:
> From: Helge Deller <deller@gmx.de>
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> hw/net/tulip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/tulip.c b/hw/net/tulip.c
> index 915e5fb595..11d866e431 100644
> --- a/hw/net/tulip.c
> +++ b/hw/net/tulip.c
> @@ -1020,7 +1020,7 @@ static void tulip_class_init(ObjectClass *klass, void *data)
>     k->exit = pci_tulip_exit;
>     k->vendor_id = PCI_VENDOR_ID_DEC;
>     k->device_id = PCI_DEVICE_ID_DEC_21143;
> -    k->subsystem_vendor_id = 0x103c;
> +    k->subsystem_vendor_id = PCI_VENDOR_ID_HP;

Seems to be first use of value introduced in patch 2. I don't know if this 
is worrh two separate patches. I'd just squash patch 2 in this patch but 
not sure what others or maintainer prefers.

Regards,
BALATON Zoltan

>     k->subsystem_id = 0x104f;
>     k->class_id = PCI_CLASS_NETWORK_ETHERNET;
>     dc->vmsd = &vmstate_pci_tulip;
>