[v2] Support discontinuous PMU counters

[PATCH v2 6/6] docs/about/deprecated: Document RISC-V "pmu-num" deprecation

Posted by Rob Bradford 2 years, 4 months ago

This has been replaced by a "pmu-mask" property that provides much more
flexibility.

Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
---
 docs/about/deprecated.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 8b136320e2..37f3414ef8 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -361,6 +361,16 @@ Specifying the iSCSI password in plain text on the command line using the
 used instead, to refer to a ``--object secret...`` instance that provides
 a password via a file, or encrypted.
 
+CPU device properties
+'''''''''''''''''''''
+
+``pmu-num=x`` on RISC-V CPUs (since 8.2)
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+In order to support more flexible counter configurations this has been
+replaced by a ``pmu-mask`` property
+
+
 Backwards compatibility
 -----------------------
 
-- 
2.41.0

Re: [PATCH v2 6/6] docs/about/deprecated: Document RISC-V "pmu-num" deprecation

Posted by Alistair Francis 2 years, 3 months ago

On Thu, Oct 12, 2023 at 12:52 AM Rob Bradford <rbradford@rivosinc.com> wrote:
>
> This has been replaced by a "pmu-mask" property that provides much more
> flexibility.
>
> Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
> ---
>  docs/about/deprecated.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 8b136320e2..37f3414ef8 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -361,6 +361,16 @@ Specifying the iSCSI password in plain text on the command line using the
>  used instead, to refer to a ``--object secret...`` instance that provides
>  a password via a file, or encrypted.
>
> +CPU device properties
> +'''''''''''''''''''''
> +
> +``pmu-num=x`` on RISC-V CPUs (since 8.2)
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +In order to support more flexible counter configurations this has been
> +replaced by a ``pmu-mask`` property

Can we give an example of how to migrate to pmu-mask?

Alistair

> +
> +
>  Backwards compatibility
>  -----------------------
>
> --
> 2.41.0
>
>

Re: [PATCH v2 6/6] docs/about/deprecated: Document RISC-V "pmu-num" deprecation

Posted by LIU Zhiwei 2 years, 4 months ago

On 2023/10/11 22:45, Rob Bradford wrote:
> This has been replaced by a "pmu-mask" property that provides much more
> flexibility.
>
> Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
> ---
>   docs/about/deprecated.rst | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 8b136320e2..37f3414ef8 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -361,6 +361,16 @@ Specifying the iSCSI password in plain text on the command line using the
>   used instead, to refer to a ``--object secret...`` instance that provides
>   a password via a file, or encrypted.
>   
> +CPU device properties
> +'''''''''''''''''''''
> +
> +``pmu-num=x`` on RISC-V CPUs (since 8.2)
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +In order to support more flexible counter configurations this has been
> +replaced by a ``pmu-mask`` property
> +
> +

Acked-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>

Zhiwei

>   Backwards compatibility
>   -----------------------
>

[PATCH v2 1/6] target/riscv: Propagate error from PMU setup
[PATCH v2 2/6] target/riscv: Don't assume PMU counters are continuous
[PATCH v2 3/6] target/riscv: Use existing PMU counter mask in FDT generation
[PATCH v2 4/6] qemu/bitops.h: Add MAKE_32BIT_MASK macro
[PATCH v2 5/6] target/riscv: Add "pmu-mask" property to replace "pmu-num"
[PATCH v2 6/6] docs/about/deprecated: Document RISC-V "pmu-num" deprecation