ppc: avocado test additions and new defaults

[RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

Posted by Nicholas Piggin 2 years, 4 months ago

POWER10 is the latest IBM Power machine. Although it is not offered in
"OPAL mode" (i.e., powernv configuration), so there is a case that it
should remain at powernv9, most of the development work is going into
powernv10 at the moment.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/ppc/pnv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index eb54f93986..f3dad5ae05 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -2195,8 +2195,6 @@ static void pnv_machine_power9_class_init(ObjectClass *oc, void *data)
 
     xfc->match_nvt = pnv_match_nvt;
 
-    mc->alias = "powernv";
-
     pmc->compat = compat;
     pmc->compat_size = sizeof(compat);
     pmc->dt_power_mgt = pnv_dt_power_mgt;
@@ -2220,6 +2218,8 @@ static void pnv_machine_power10_class_init(ObjectClass *oc, void *data)
     mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
     compat_props_add(mc->compat_props, phb_compat, G_N_ELEMENTS(phb_compat));
 
+    mc->alias = "powernv";
+
     pmc->compat = compat;
     pmc->compat_size = sizeof(compat);
     pmc->dt_power_mgt = pnv_dt_power_mgt;
-- 
2.42.0

Re: [RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

Posted by Cédric Le Goater 2 years, 3 months ago

On 10/10/23 09:52, Nicholas Piggin wrote:
> POWER10 is the latest IBM Power machine. Although it is not offered in
> "OPAL mode" (i.e., powernv configuration), so there is a case that it
> should remain at powernv9, most of the development work is going into
> powernv10 at the moment.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

I think we would update skiboot to v7.1 also.

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.



> ---
>   hw/ppc/pnv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index eb54f93986..f3dad5ae05 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -2195,8 +2195,6 @@ static void pnv_machine_power9_class_init(ObjectClass *oc, void *data)
>   
>       xfc->match_nvt = pnv_match_nvt;
>   
> -    mc->alias = "powernv";
> -
>       pmc->compat = compat;
>       pmc->compat_size = sizeof(compat);
>       pmc->dt_power_mgt = pnv_dt_power_mgt;
> @@ -2220,6 +2218,8 @@ static void pnv_machine_power10_class_init(ObjectClass *oc, void *data)
>       mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
>       compat_props_add(mc->compat_props, phb_compat, G_N_ELEMENTS(phb_compat));
>   
> +    mc->alias = "powernv";
> +
>       pmc->compat = compat;
>       pmc->compat_size = sizeof(compat);
>       pmc->dt_power_mgt = pnv_dt_power_mgt;

Re: [RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

Posted by Joel Stanley 2 years, 4 months ago

On Tue, 10 Oct 2023 at 18:24, Nicholas Piggin <npiggin@gmail.com> wrote:
>
> POWER10 is the latest IBM Power machine. Although it is not offered in
> "OPAL mode" (i.e., powernv configuration), so there is a case that it
> should remain at powernv9, most of the development work is going into
> powernv10 at the moment.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Reviewed-by: Joel Stanley <joel@jms.id.au>

Do we need to update the docs?

We should consider updating the skiboot to the latest release too.


> ---
>  hw/ppc/pnv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index eb54f93986..f3dad5ae05 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -2195,8 +2195,6 @@ static void pnv_machine_power9_class_init(ObjectClass *oc, void *data)
>
>      xfc->match_nvt = pnv_match_nvt;
>
> -    mc->alias = "powernv";
> -
>      pmc->compat = compat;
>      pmc->compat_size = sizeof(compat);
>      pmc->dt_power_mgt = pnv_dt_power_mgt;
> @@ -2220,6 +2218,8 @@ static void pnv_machine_power10_class_init(ObjectClass *oc, void *data)
>      mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
>      compat_props_add(mc->compat_props, phb_compat, G_N_ELEMENTS(phb_compat));
>
> +    mc->alias = "powernv";
> +
>      pmc->compat = compat;
>      pmc->compat_size = sizeof(compat);
>      pmc->dt_power_mgt = pnv_dt_power_mgt;
> --
> 2.42.0
>
>

Re: [RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

Posted by Nicholas Piggin 2 years, 4 months ago

On Tue Oct 10, 2023 at 10:05 PM AEST, Joel Stanley wrote:
> On Tue, 10 Oct 2023 at 18:24, Nicholas Piggin <npiggin@gmail.com> wrote:
> >
> > POWER10 is the latest IBM Power machine. Although it is not offered in
> > "OPAL mode" (i.e., powernv configuration), so there is a case that it
> > should remain at powernv9, most of the development work is going into
> > powernv10 at the moment.
> >
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Do we need to update the docs?

What did you have in mind? Add some powernv10 examples?

> We should consider updating the skiboot to the latest release too.

Yeah I will do that (and SLOF as well).

Thanks,
Nick

Re: [RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

Posted by Joel Stanley 2 years, 3 months ago

On Wed, 11 Oct 2023 at 07:28, Nicholas Piggin <npiggin@gmail.com> wrote:
>
> On Tue Oct 10, 2023 at 10:05 PM AEST, Joel Stanley wrote:
> > On Tue, 10 Oct 2023 at 18:24, Nicholas Piggin <npiggin@gmail.com> wrote:
> > >
> > > POWER10 is the latest IBM Power machine. Although it is not offered in
> > > "OPAL mode" (i.e., powernv configuration), so there is a case that it
> > > should remain at powernv9, most of the development work is going into
> > > powernv10 at the moment.
> > >
> > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> >
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> >
> > Do we need to update the docs?
>
> What did you have in mind? Add some powernv10 examples?

Nothing in mind. The docs don't actually mention which cpu is the
default, which has the upside of us not needing to update it.

Cheers,

Joel