tests: Clean up global variables shadowing

[PATCH 00/10] tests: Clean up global variables shadowing

Philippe Mathieu-Daudé posted 10 patches 1 year, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231009100251.56019-1-philmd@linaro.org

Maintainers: John Snow <jsnow@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Tyrone Ting <kfting@nuvoton.com>, Hao Wu <wuhaotsh@google.com>, Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>

softmmu/qtest.c                   | 16 ++++++++--------
tests/qtest/cdrom-test.c          |  6 +++---
tests/qtest/hd-geo-test.c         | 12 ++++++++----
tests/qtest/npcm7xx_adc-test.c    | 14 +++++++-------
tests/qtest/rtl8139-test.c        | 12 ++++++------
tests/qtest/virtio-scsi-test.c    |  2 +-
tests/unit/test-aio-multithread.c | 16 ++++++++--------
tests/unit/test-aio.c             |  4 ++--
tests/unit/test-coroutine.c       | 12 ++++++------
tests/unit/test-throttle.c        |  1 -
10 files changed, 49 insertions(+), 46 deletions(-)

Expand all Fold all

[PATCH 00/10] tests: Clean up global variables shadowing

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Clean up global variables shadowing in tests/
in order to be able to use -Wshadow with Clang.

Philippe Mathieu-Daudé (10):
  system/qtest: Clean up global variable shadowing in
    qtest_server_init()
  tests/throttle: Clean up global variable shadowing
  tests/virtio-scsi: Clean up global variable shadowing
  tests/cdrom-test: Clean up global variable shadowing in
    prepare_image()
  tests/hd-geo-test: Clean up global variable shadowing
  tests/rtl8139: Clean up global variable shadowing
  tests/npcm7xx_adc: Clean up global variable shadowing
  tests/aio: Clean up global variable shadowing
  tests/aio-multithread: Clean up global variable shadowing
  tests/coroutine: Clean up global variable shadowing

 softmmu/qtest.c                   | 16 ++++++++--------
 tests/qtest/cdrom-test.c          |  6 +++---
 tests/qtest/hd-geo-test.c         | 12 ++++++++----
 tests/qtest/npcm7xx_adc-test.c    | 14 +++++++-------
 tests/qtest/rtl8139-test.c        | 12 ++++++------
 tests/qtest/virtio-scsi-test.c    |  2 +-
 tests/unit/test-aio-multithread.c | 16 ++++++++--------
 tests/unit/test-aio.c             |  4 ++--
 tests/unit/test-coroutine.c       | 12 ++++++------
 tests/unit/test-throttle.c        |  1 -
 10 files changed, 49 insertions(+), 46 deletions(-)

-- 
2.41.0

Re: [PATCH 00/10] tests: Clean up global variables shadowing

Posted by Thomas Huth 1 year, 1 month ago

On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:
> Clean up global variables shadowing in tests/
> in order to be able to use -Wshadow with Clang.
> 
> Philippe Mathieu-Daudé (10):
>    system/qtest: Clean up global variable shadowing in
>      qtest_server_init()
>    tests/throttle: Clean up global variable shadowing
>    tests/virtio-scsi: Clean up global variable shadowing
>    tests/cdrom-test: Clean up global variable shadowing in
>      prepare_image()
>    tests/hd-geo-test: Clean up global variable shadowing
>    tests/rtl8139: Clean up global variable shadowing
>    tests/npcm7xx_adc: Clean up global variable shadowing
>    tests/aio: Clean up global variable shadowing
>    tests/aio-multithread: Clean up global variable shadowing
>    tests/coroutine: Clean up global variable shadowing

Thanks, I've queued now everything except for patch 5 and 9 that both still 
had unresolved comments.

  Thomas