vfio: memory leak fix and code cleanup

[PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

Posted by Zhenzhong Duan 2 years, 4 months ago

No functional changes.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 include/hw/s390x/vfio-ccw.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/s390x/vfio-ccw.h b/include/hw/s390x/vfio-ccw.h
index 63a909eb7e..4209d27657 100644
--- a/include/hw/s390x/vfio-ccw.h
+++ b/include/hw/s390x/vfio-ccw.h
@@ -22,6 +22,4 @@
 #define TYPE_VFIO_CCW "vfio-ccw"
 OBJECT_DECLARE_SIMPLE_TYPE(VFIOCCWDevice, VFIO_CCW)
 
-#define TYPE_VFIO_CCW "vfio-ccw"
-
 #endif
-- 
2.34.1

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

Posted by Eric Farman 2 years, 4 months ago

On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote:
> No functional changes.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>

I see Cedric has already queued this, but FWIW:

Reviewed-by: Eric Farman <farman@linux.ibm.com>

> ---
>  include/hw/s390x/vfio-ccw.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/s390x/vfio-ccw.h b/include/hw/s390x/vfio-
> ccw.h
> index 63a909eb7e..4209d27657 100644
> --- a/include/hw/s390x/vfio-ccw.h
> +++ b/include/hw/s390x/vfio-ccw.h
> @@ -22,6 +22,4 @@
>  #define TYPE_VFIO_CCW "vfio-ccw"
>  OBJECT_DECLARE_SIMPLE_TYPE(VFIOCCWDevice, VFIO_CCW)
>  
> -#define TYPE_VFIO_CCW "vfio-ccw"
> -
>  #endif

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

Posted by Cédric Le Goater 2 years, 4 months ago

On 10/9/23 20:58, Eric Farman wrote:
> On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote:
>> No functional changes.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> 
> I see Cedric has already queued this, but FWIW:
> 
> Reviewed-by: Eric Farman <farman@linux.ibm.com>

I will take the new tags when I rebase.

Thanks,

C.


> 
>> ---
>>   include/hw/s390x/vfio-ccw.h | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/include/hw/s390x/vfio-ccw.h b/include/hw/s390x/vfio-
>> ccw.h
>> index 63a909eb7e..4209d27657 100644
>> --- a/include/hw/s390x/vfio-ccw.h
>> +++ b/include/hw/s390x/vfio-ccw.h
>> @@ -22,6 +22,4 @@
>>   #define TYPE_VFIO_CCW "vfio-ccw"
>>   OBJECT_DECLARE_SIMPLE_TYPE(VFIOCCWDevice, VFIO_CCW)
>>   
>> -#define TYPE_VFIO_CCW "vfio-ccw"
>> -
>>   #endif
>

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

On 9/10/23 04:20, Zhenzhong Duan wrote:
> No functional changes.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   include/hw/s390x/vfio-ccw.h | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[PATCH 1/3] vfio/pci: Fix a potential memory leak in vfio_listener_region_add
[PATCH 2/3] vfio/ap: Remove pointless apdev variable
[PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW