[v3] (few more) Steps towards enabling -Wshadow

[PATCH v3 00/16] (few more) Steps towards enabling -Wshadow

Philippe Mathieu-Daudé posted 16 patches 6 months, 3 weeks ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20231004120019.93101-1-philmd@linaro.org

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, "Alex Bennée" <alex.bennee@linaro.org>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Mads Ynddal <mads@ynddal.dk>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Akihiko Odaki <akihiko.odaki@daynix.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>

include/hw/audio/soundhw.h      |  2 +-
include/net/net.h               |  6 +++---
include/qemu/guest-random.h     |  8 ++++----
include/qemu/plugin.h           |  4 ++--
include/qom/object_interfaces.h | 16 ++++++++--------
include/semihosting/semihost.h  |  2 +-
include/sysemu/os-posix.h       |  4 ++--
include/sysemu/tpm.h            |  2 +-
trace/control.h                 |  4 ++--
hw/audio/soundhw.c              |  6 +++---
hw/ide/ahci.c                   |  4 +---
net/net.c                       | 14 +++++++-------
os-posix.c                      | 12 ++++++------
plugins/loader.c                |  4 ++--
qemu-img.c                      | 22 +++++++++++-----------
qemu-io.c                       |  4 ++--
qom/object_interfaces.c         | 16 ++++++++--------
semihosting/arm-compat-semi.c   |  5 ++++-
semihosting/config.c            |  8 ++++----
softmmu/tpm.c                   |  6 +++---
softmmu/vl.c                    | 26 +++++++++++++-------------
stubs/semihost.c                |  2 +-
trace/control.c                 |  4 ++--
util/cutils.c                   |  1 -
util/guest-random.c             |  6 +++---
ui/cocoa.m                      |  4 ++--
26 files changed, 96 insertions(+), 96 deletions(-)

Expand all Fold all

[PATCH v3 00/16] (few more) Steps towards enabling -Wshadow

Posted by Philippe Mathieu-Daudé 6 months, 3 weeks ago

Since v2:
- Rebased (many patches merged by Markus)
- Updated arm/ide patches (Markus, Peter)
- More patches for optarg (3)

Since v1:
- Addressed review comments
- Added R-b tags
- More patches

For rational see Markus cover on
https://lore.kernel.org/qemu-devel/20230831132546.3525721-1-armbru@redhat.com/

Philippe Mathieu-Daudé (16):
  hw/audio/soundhw: Clean up global variable shadowing
  hw/ide/ahci: Clean up local variable shadowing
  net/net: Clean up global variable shadowing
  os-posix: Clean up global variable shadowing
  plugins/loader: Clean up global variable shadowing
  qemu-img: Clean up global variable shadowing
  qemu-io: Clean up global variable shadowing
  qom/object_interfaces: Clean up global variable shadowing
  semihosting: Clean up global variable shadowing
  ui/cocoa: Clean up global variable shadowing
  util/cutils: Clean up global variable shadowing in
    get_relocated_path()
  util/guest-random: Clean up global variable shadowing
  semihosting/arm-compat: Clean up local variable shadowing
  softmmu/vl: Clean up global variable shadowing
  sysemu/tpm: Clean up global variable shadowing
  trace/control: Clean up global variable shadowing

 include/hw/audio/soundhw.h      |  2 +-
 include/net/net.h               |  6 +++---
 include/qemu/guest-random.h     |  8 ++++----
 include/qemu/plugin.h           |  4 ++--
 include/qom/object_interfaces.h | 16 ++++++++--------
 include/semihosting/semihost.h  |  2 +-
 include/sysemu/os-posix.h       |  4 ++--
 include/sysemu/tpm.h            |  2 +-
 trace/control.h                 |  4 ++--
 hw/audio/soundhw.c              |  6 +++---
 hw/ide/ahci.c                   |  4 +---
 net/net.c                       | 14 +++++++-------
 os-posix.c                      | 12 ++++++------
 plugins/loader.c                |  4 ++--
 qemu-img.c                      | 22 +++++++++++-----------
 qemu-io.c                       |  4 ++--
 qom/object_interfaces.c         | 16 ++++++++--------
 semihosting/arm-compat-semi.c   |  5 ++++-
 semihosting/config.c            |  8 ++++----
 softmmu/tpm.c                   |  6 +++---
 softmmu/vl.c                    | 26 +++++++++++++-------------
 stubs/semihost.c                |  2 +-
 trace/control.c                 |  4 ++--
 util/cutils.c                   |  1 -
 util/guest-random.c             |  6 +++---
 ui/cocoa.m                      |  4 ++--
 26 files changed, 96 insertions(+), 96 deletions(-)

-- 
2.41.0

Re: [PATCH v3 00/16] (few more) Steps towards enabling -Wshadow

Posted by Markus Armbruster 6 months, 3 weeks ago

Queued, thanks!

Re: [PATCH v3 00/16] (few more) Steps towards enabling -Wshadow

Posted by Markus Armbruster 6 months, 3 weeks ago

Queued.  Thanks!

Re: [PATCH v3 00/16] (few more) Steps towards enabling -Wshadow

Posted by Richard Henderson 6 months, 3 weeks ago

On 10/4/23 05:00, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (16):
>    hw/audio/soundhw: Clean up global variable shadowing
>    hw/ide/ahci: Clean up local variable shadowing
>    net/net: Clean up global variable shadowing
>    os-posix: Clean up global variable shadowing
>    plugins/loader: Clean up global variable shadowing
>    qemu-img: Clean up global variable shadowing
>    qemu-io: Clean up global variable shadowing
>    qom/object_interfaces: Clean up global variable shadowing
>    semihosting: Clean up global variable shadowing
>    ui/cocoa: Clean up global variable shadowing
>    util/cutils: Clean up global variable shadowing in
>      get_relocated_path()
>    util/guest-random: Clean up global variable shadowing
>    semihosting/arm-compat: Clean up local variable shadowing
>    softmmu/vl: Clean up global variable shadowing
>    sysemu/tpm: Clean up global variable shadowing
>    trace/control: Clean up global variable shadowing

Series:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~