[v2] MAINTAINERS: Collect unmaintained files under PPC entries

[PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

Posted by Cédric Le Goater 2 years, 4 months ago

Cc: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e40f7f71d651..174bcfe39210 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3551,6 +3551,7 @@ PPC TCG target
 M: Richard Henderson <richard.henderson@linaro.org>
 S: Odd Fixes
 F: tcg/ppc/
+F: tests/tcg/ppc*
 
 RISC-V TCG target
 M: Palmer Dabbelt <palmer@dabbelt.com>
-- 
2.41.0

Re: [PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

Posted by Thomas Huth 2 years, 3 months ago

On 02/10/2023 17.51, Cédric Le Goater wrote:
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e40f7f71d651..174bcfe39210 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3551,6 +3551,7 @@ PPC TCG target
>   M: Richard Henderson <richard.henderson@linaro.org>
>   S: Odd Fixes
>   F: tcg/ppc/
> +F: tests/tcg/ppc*

Sorry, but I think this patch is wrong. This section is about the TCG *host* 
backend (tcg/ppc/), but tests/tcg/ppc* is about the TCG *guest* frontend.

I just noticed since I just wrote a patch that adds the tests/tcg/ 
subfolders to the right sections:

  https://lore.kernel.org/qemu-devel/20231018062401.20746-1-thuth@redhat.com/

The ppc* subfolders are included there, too, so I'd suggest to drop this 
patch here.

  Thomas

Re: [PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

Posted by Cédric Le Goater 2 years, 3 months ago

On 10/18/23 08:27, Thomas Huth wrote:
> On 02/10/2023 17.51, Cédric Le Goater wrote:
>> Cc: Richard Henderson <richard.henderson@linaro.org>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e40f7f71d651..174bcfe39210 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3551,6 +3551,7 @@ PPC TCG target
>>   M: Richard Henderson <richard.henderson@linaro.org>
>>   S: Odd Fixes
>>   F: tcg/ppc/
>> +F: tests/tcg/ppc*
> 
> Sorry, but I think this patch is wrong. This section is about the TCG *host* backend (tcg/ppc/), but tests/tcg/ppc* is about the TCG *guest* frontend.
> 
> I just noticed since I just wrote a patch that adds the tests/tcg/ subfolders to the right sections:
> 
>   https://lore.kernel.org/qemu-devel/20231018062401.20746-1-thuth@redhat.com/
> 
> The ppc* subfolders are included there, too, so I'd suggest to drop this patch here.

ok. Good for me.

Thanks,

C.