1. Patchew
  2. QEMU
  3. [PATCH 00/31] September maintainer omnibus (tests, gdbstub, plugins)
  4. View patch

[PATCH 04/31] docs: mark CRIS support as deprecated

Alex Bennée posted 31 patches 2 years, 4 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Yanan Wang <wangyanan55@huawei.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Song Gao <gaosong@loongson.cn>, Xiaojuan Yang <yangxiaojuan@loongson.cn>, Nicholas Piggin <npiggin@gmail.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>, Weiwei Li <liweiwei@iscas.ac.cn>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Radoslaw Biernacki <rad@semihalf.com>, Leif Lindholm <quic_llindhol@quicinc.com>, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
[PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Alex Bennée 2 years, 4 months ago 
This might be premature but while streamling the avocado tests I
realised the only tests we have are "check-tcg" ones. The aging
fedora-criss-cross image works well enough for developers but can't be
used in CI as we need supported build platforms to build QEMU.

Does this mean the writing is on the wall for this architecture?

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Rabin Vincent <rabinv@axis.com>
Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 docs/about/deprecated.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index dc4da95329..7cfe313aa6 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the
 used instead, to refer to a ``--object secret...`` instance that provides
 a password via a file, or encrypted.
 
+TCG CPUs
+--------
+
+CRIS CPU architecture (since 8.1)
+'''''''''''''''''''''''''''''''''
+
+The CRIS architecture was pulled from Linux in 4.17 and the compiler
+is no longer packaged in any distro making it harder to run the
+``check-tcg`` tests. Unless we can improve the testing situation there
+is a chance the code will bitrot without anyone noticing.
+
 Backwards compatibility
 -----------------------
 
-- 
2.39.2
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Alex Bennée 2 years, 4 months ago 
Alex Bennée <alex.bennee@linaro.org> writes:

> This might be premature but while streamling the avocado tests I
> realised the only tests we have are "check-tcg" ones. The aging
> fedora-criss-cross image works well enough for developers but can't be
> used in CI as we need supported build platforms to build QEMU.
>
> Does this mean the writing is on the wall for this architecture?
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Rabin Vincent <rabinv@axis.com>
> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

doh, I meant:

Edgar E. Iglesias <edgar.iglesias@gmail.com>

> ---
>  docs/about/deprecated.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index dc4da95329..7cfe313aa6 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the
>  used instead, to refer to a ``--object secret...`` instance that provides
>  a password via a file, or encrypted.
>  
> +TCG CPUs
> +--------
> +
> +CRIS CPU architecture (since 8.1)
> +'''''''''''''''''''''''''''''''''
> +
> +The CRIS architecture was pulled from Linux in 4.17 and the compiler
> +is no longer packaged in any distro making it harder to run the
> +``check-tcg`` tests. Unless we can improve the testing situation there
> +is a chance the code will bitrot without anyone noticing.
> +
>  Backwards compatibility
>  -----------------------


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Daniel P. Berrangé 2 years, 4 months ago 
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> This might be premature but while streamling the avocado tests I
> realised the only tests we have are "check-tcg" ones. The aging
> fedora-criss-cross image works well enough for developers but can't be
> used in CI as we need supported build platforms to build QEMU.
> 
> Does this mean the writing is on the wall for this architecture?
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Rabin Vincent <rabinv@axis.com>
> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>  docs/about/deprecated.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index dc4da95329..7cfe313aa6 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the
>  used instead, to refer to a ``--object secret...`` instance that provides
>  a password via a file, or encrypted.
>  
> +TCG CPUs
> +--------
> +
> +CRIS CPU architecture (since 8.1)
> +'''''''''''''''''''''''''''''''''
> +
> +The CRIS architecture was pulled from Linux in 4.17 and the compiler
> +is no longer packaged in any distro making it harder to run the
> +``check-tcg`` tests. Unless we can improve the testing situation there
> +is a chance the code will bitrot without anyone noticing.

Deprecated is generally a warning that we intend to delete the
feature.   If we're just going to relegate it to untested
status (what I'd call "tier 3" quality), then we should document
that elsewhere.  I don't mind which way we go.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Alex Bennée 2 years, 4 months ago 
Daniel P. Berrangé <berrange@redhat.com> writes:

> On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
>> This might be premature but while streamling the avocado tests I
>> realised the only tests we have are "check-tcg" ones. The aging
>> fedora-criss-cross image works well enough for developers but can't be
>> used in CI as we need supported build platforms to build QEMU.
>> 
>> Does this mean the writing is on the wall for this architecture?
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Rabin Vincent <rabinv@axis.com>
>> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>> ---
>>  docs/about/deprecated.rst | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>> 
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index dc4da95329..7cfe313aa6 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the
>>  used instead, to refer to a ``--object secret...`` instance that provides
>>  a password via a file, or encrypted.
>>  
>> +TCG CPUs
>> +--------
>> +
>> +CRIS CPU architecture (since 8.1)
>> +'''''''''''''''''''''''''''''''''
>> +
>> +The CRIS architecture was pulled from Linux in 4.17 and the compiler
>> +is no longer packaged in any distro making it harder to run the
>> +``check-tcg`` tests. Unless we can improve the testing situation there
>> +is a chance the code will bitrot without anyone noticing.
>
> Deprecated is generally a warning that we intend to delete the
> feature.   If we're just going to relegate it to untested
> status (what I'd call "tier 3" quality), then we should document
> that elsewhere.  I don't mind which way we go.

We do have reasonably good coverage with tests/tcg/cris but of course
without a compiler we can't build them.

Both nios2 and microblaze have build-toolchain scripts which can be used
to re-create containers. However my preference is having pre-built
toolchains hosted by others like we do for loongarch, hexagon, xtensa
and tricore. Then the docker image can simply curl them into an image.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Edgar E. Iglesias 2 years, 4 months ago 
On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org> wrote:

>
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
> > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> >> This might be premature but while streamling the avocado tests I
> >> realised the only tests we have are "check-tcg" ones. The aging
> >> fedora-criss-cross image works well enough for developers but can't be
> >> used in CI as we need supported build platforms to build QEMU.
> >>
> >> Does this mean the writing is on the wall for this architecture?
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> Cc: Rabin Vincent <rabinv@axis.com>
> >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> >> ---
> >>  docs/about/deprecated.rst | 11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >>
> >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> >> index dc4da95329..7cfe313aa6 100644
> >> --- a/docs/about/deprecated.rst
> >> +++ b/docs/about/deprecated.rst
> >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the
> command line using the
> >>  used instead, to refer to a ``--object secret...`` instance that
> provides
> >>  a password via a file, or encrypted.
> >>
> >> +TCG CPUs
> >> +--------
> >> +
> >> +CRIS CPU architecture (since 8.1)
> >> +'''''''''''''''''''''''''''''''''
> >> +
> >> +The CRIS architecture was pulled from Linux in 4.17 and the compiler
> >> +is no longer packaged in any distro making it harder to run the
> >> +``check-tcg`` tests. Unless we can improve the testing situation there
> >> +is a chance the code will bitrot without anyone noticing.
> >
> > Deprecated is generally a warning that we intend to delete the
> > feature.   If we're just going to relegate it to untested
> > status (what I'd call "tier 3" quality), then we should document
> > that elsewhere.  I don't mind which way we go.
>
> We do have reasonably good coverage with tests/tcg/cris but of course
> without a compiler we can't build them.
>
> Both nios2 and microblaze have build-toolchain scripts which can be used
> to re-create containers. However my preference is having pre-built
> toolchains hosted by others like we do for loongarch, hexagon, xtensa
> and tricore. Then the docker image can simply curl them into an image.
>
>
Yeah, I guess it's time to deprecate it...

Cheers,
Edgar


> --
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
>
>
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Philippe Mathieu-Daudé 2 years ago 
On 25/9/23 19:17, Edgar E. Iglesias wrote:
> 
> On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org 
> <mailto:alex.bennee@linaro.org>> wrote:
> 
> 
>     Daniel P. Berrangé <berrange@redhat.com
>     <mailto:berrange@redhat.com>> writes:
> 
>      > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
>      >> This might be premature but while streamling the avocado tests I
>      >> realised the only tests we have are "check-tcg" ones. The aging
>      >> fedora-criss-cross image works well enough for developers but
>     can't be
>      >> used in CI as we need supported build platforms to build QEMU.
>      >>
>      >> Does this mean the writing is on the wall for this architecture?
>      >>
>      >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org
>     <mailto:alex.bennee@linaro.org>>
>      >> Cc: Rabin Vincent <rabinv@axis.com <mailto:rabinv@axis.com>>
>      >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com
>     <mailto:edgar.iglesias@xilinx.com>>
>      >> ---
>      >>  docs/about/deprecated.rst | 11 +++++++++++
>      >>  1 file changed, 11 insertions(+)
>      >>
>      >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>      >> index dc4da95329..7cfe313aa6 100644
>      >> --- a/docs/about/deprecated.rst
>      >> +++ b/docs/about/deprecated.rst
>      >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text
>     on the command line using the
>      >>  used instead, to refer to a ``--object secret...`` instance
>     that provides
>      >>  a password via a file, or encrypted.
>      >>
>      >> +TCG CPUs
>      >> +--------
>      >> +
>      >> +CRIS CPU architecture (since 8.1)
>      >> +'''''''''''''''''''''''''''''''''
>      >> +
>      >> +The CRIS architecture was pulled from Linux in 4.17 and the
>     compiler
>      >> +is no longer packaged in any distro making it harder to run the
>      >> +``check-tcg`` tests. Unless we can improve the testing
>     situation there
>      >> +is a chance the code will bitrot without anyone noticing.
>      >
>      > Deprecated is generally a warning that we intend to delete the
>      > feature.   If we're just going to relegate it to untested
>      > status (what I'd call "tier 3" quality), then we should document
>      > that elsewhere.  I don't mind which way we go.
> 
>     We do have reasonably good coverage with tests/tcg/cris but of course
>     without a compiler we can't build them.
> 
>     Both nios2 and microblaze have build-toolchain scripts which can be used
>     to re-create containers. However my preference is having pre-built
>     toolchains hosted by others like we do for loongarch, hexagon, xtensa
>     and tricore. Then the docker image can simply curl them into an image.
> 
> 
> Yeah, I guess it's time to deprecate it...

Is that an informal Acked-by? (:

> 
> Cheers,
> Edgar
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Edgar E. Iglesias 2 years ago 
On Wed, Jan 24, 2024 at 12:06 PM Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:

> On 25/9/23 19:17, Edgar E. Iglesias wrote:
> >
> > On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée <alex.bennee@linaro.org
> > <mailto:alex.bennee@linaro.org>> wrote:
> >
> >
> >     Daniel P. Berrangé <berrange@redhat.com
> >     <mailto:berrange@redhat.com>> writes:
> >
> >      > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> >      >> This might be premature but while streamling the avocado tests I
> >      >> realised the only tests we have are "check-tcg" ones. The aging
> >      >> fedora-criss-cross image works well enough for developers but
> >     can't be
> >      >> used in CI as we need supported build platforms to build QEMU.
> >      >>
> >      >> Does this mean the writing is on the wall for this architecture?
> >      >>
> >      >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org
> >     <mailto:alex.bennee@linaro.org>>
> >      >> Cc: Rabin Vincent <rabinv@axis.com <mailto:rabinv@axis.com>>
> >      >> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com
> >     <mailto:edgar.iglesias@xilinx.com>>
> >      >> ---
> >      >>  docs/about/deprecated.rst | 11 +++++++++++
> >      >>  1 file changed, 11 insertions(+)
> >      >>
> >      >> diff --git a/docs/about/deprecated.rst
> b/docs/about/deprecated.rst
> >      >> index dc4da95329..7cfe313aa6 100644
> >      >> --- a/docs/about/deprecated.rst
> >      >> +++ b/docs/about/deprecated.rst
> >      >> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text
> >     on the command line using the
> >      >>  used instead, to refer to a ``--object secret...`` instance
> >     that provides
> >      >>  a password via a file, or encrypted.
> >      >>
> >      >> +TCG CPUs
> >      >> +--------
> >      >> +
> >      >> +CRIS CPU architecture (since 8.1)
> >      >> +'''''''''''''''''''''''''''''''''
> >      >> +
> >      >> +The CRIS architecture was pulled from Linux in 4.17 and the
> >     compiler
> >      >> +is no longer packaged in any distro making it harder to run the
> >      >> +``check-tcg`` tests. Unless we can improve the testing
> >     situation there
> >      >> +is a chance the code will bitrot without anyone noticing.
> >      >
> >      > Deprecated is generally a warning that we intend to delete the
> >      > feature.   If we're just going to relegate it to untested
> >      > status (what I'd call "tier 3" quality), then we should document
> >      > that elsewhere.  I don't mind which way we go.
> >
> >     We do have reasonably good coverage with tests/tcg/cris but of course
> >     without a compiler we can't build them.
> >
> >     Both nios2 and microblaze have build-toolchain scripts which can be
> used
> >     to re-create containers. However my preference is having pre-built
> >     toolchains hosted by others like we do for loongarch, hexagon, xtensa
> >     and tricore. Then the docker image can simply curl them into an
> image.
> >
> >
> > Yeah, I guess it's time to deprecate it...
>
> Is that an informal Acked-by? (:
>
>
OK with me!

Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Re: [PATCH 04/31] docs: mark CRIS support as deprecated
Posted by Daniel P. Berrangé 2 years, 4 months ago 
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> This might be premature but while streamling the avocado tests I
> realised the only tests we have are "check-tcg" ones. The aging
> fedora-criss-cross image works well enough for developers but can't be
> used in CI as we need supported build platforms to build QEMU.
> 
> Does this mean the writing is on the wall for this architecture?

It was deleted in Linux, and GCC dropped the cris-*linux target,
but GCC keeps other cris targets.

IOW, at very least, it has become a niche use case target.

We don't need Linux/GCC support as a pre-requisite for having a
target in QEMU, but it sure makes it increasingly challenging
to test.

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Rabin Vincent <rabinv@axis.com>
> Cc: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>  docs/about/deprecated.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index dc4da95329..7cfe313aa6 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -399,6 +399,17 @@ Specifying the iSCSI password in plain text on the command line using the
>  used instead, to refer to a ``--object secret...`` instance that provides
>  a password via a file, or encrypted.
>  
> +TCG CPUs
> +--------
> +
> +CRIS CPU architecture (since 8.1)
> +'''''''''''''''''''''''''''''''''
> +
> +The CRIS architecture was pulled from Linux in 4.17 and the compiler
> +is no longer packaged in any distro making it harder to run the
> +``check-tcg`` tests. Unless we can improve the testing situation there
> +is a chance the code will bitrot without anyone noticing.
> +
>  Backwards compatibility
>  -----------------------
>  
> -- 
> 2.39.2
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.