audio: don't abort on f32 audio format in wav backend

[PATCH] audio: don't abort on f32 audio format in wav backend

Posted by Daniel P. Berrangé 2 years, 4 months ago

Print a debug message as is done for other unsupported audio formats
to give the user the chance to understand their mistake.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 audio/wavaudio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index 6445a2cb90..e70e5ee0c3 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
         dolog ("WAVE files can not handle 32bit formats\n");
         return -1;
 
+    case AUDIO_FORMAT_F32:
+        dolog("WAVE files can not handle float formats\n");
+        return -1;
+
     default:
         abort();
     }
-- 
2.41.0

Re: [PATCH] audio: don't abort on f32 audio format in wav backend

Posted by Marc-André Lureau 2 years, 3 months ago

On Fri, Sep 22, 2023 at 7:19 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Print a debug message as is done for other unsupported audio formats
> to give the user the chance to understand their mistake.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  audio/wavaudio.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/audio/wavaudio.c b/audio/wavaudio.c
> index 6445a2cb90..e70e5ee0c3 100644
> --- a/audio/wavaudio.c
> +++ b/audio/wavaudio.c
> @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
>          dolog ("WAVE files can not handle 32bit formats\n");
>          return -1;
>
> +    case AUDIO_FORMAT_F32:
> +        dolog("WAVE files can not handle float formats\n");
> +        return -1;
> +
>      default:
>          abort();
>      }
> --
> 2.41.0
>

Re: [PATCH] audio: don't abort on f32 audio format in wav backend

Posted by Daniel P. Berrangé 2 years, 3 months ago

Ping, for anyone to review this trivial patch....

On Fri, Sep 22, 2023 at 04:18:58PM +0100, Daniel P. Berrangé wrote:
> Print a debug message as is done for other unsupported audio formats
> to give the user the chance to understand their mistake.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  audio/wavaudio.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/audio/wavaudio.c b/audio/wavaudio.c
> index 6445a2cb90..e70e5ee0c3 100644
> --- a/audio/wavaudio.c
> +++ b/audio/wavaudio.c
> @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
>          dolog ("WAVE files can not handle 32bit formats\n");
>          return -1;
>  
> +    case AUDIO_FORMAT_F32:
> +        dolog("WAVE files can not handle float formats\n");
> +        return -1;
> +
>      default:
>          abort();
>      }
> -- 
> 2.41.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|