[v3] qemu-img: rebase: add compression support

[PATCH v3 0/8] qemu-img: rebase: add compression support

Posted by Andrey Drobyshev via 7 months, 2 weeks ago

v2 --> v3:
 * Patch 3/8: fixed logic in the if statement, so that we align on blk
   when blk_old_backing == NULL;
 * Patch 4/8: comment fix;
 * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)"
   statements.

v2: https://lists.nongnu.org/archive/html/qemu-block/2023-09/msg00448.html

Andrey Drobyshev (8):
  qemu-img: rebase: stop when reaching EOF of old backing file
  qemu-iotests: 024: add rebasing test case for overlay_size >
    backing_size
  qemu-img: rebase: use backing files' BlockBackend for buffer alignment
  qemu-img: add chunk size parameter to compare_buffers()
  qemu-img: rebase: avoid unnecessary COW operations
  iotests/{024, 271}: add testcases for qemu-img rebase
  qemu-img: add compression option to rebase subcommand
  iotests: add tests for "qemu-img rebase" with compression

 docs/tools/qemu-img.rst    |   6 +-
 qemu-img-cmds.hx           |   4 +-
 qemu-img.c                 | 136 ++++++++++++++++++++++--------
 tests/qemu-iotests/024     | 117 ++++++++++++++++++++++++++
 tests/qemu-iotests/024.out |  73 ++++++++++++++++
 tests/qemu-iotests/271     | 131 +++++++++++++++++++++++++++++
 tests/qemu-iotests/271.out |  82 ++++++++++++++++++
 tests/qemu-iotests/314     | 165 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/314.out |  75 +++++++++++++++++
 9 files changed, 752 insertions(+), 37 deletions(-)
 create mode 100755 tests/qemu-iotests/314
 create mode 100644 tests/qemu-iotests/314.out

-- 
2.39.3

Re: [PATCH v3 0/8] qemu-img: rebase: add compression support

Posted by Kevin Wolf 6 months, 2 weeks ago

Am 19.09.2023 um 18:57 hat Andrey Drobyshev geschrieben:
> v2 --> v3:
>  * Patch 3/8: fixed logic in the if statement, so that we align on blk
>    when blk_old_backing == NULL;
>  * Patch 4/8: comment fix;
>  * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)"
>    statements.
> 
> v2: https://lists.nongnu.org/archive/html/qemu-block/2023-09/msg00448.html
> 
> Andrey Drobyshev (8):
>   qemu-img: rebase: stop when reaching EOF of old backing file
>   qemu-iotests: 024: add rebasing test case for overlay_size >
>     backing_size
>   qemu-img: rebase: use backing files' BlockBackend for buffer alignment
>   qemu-img: add chunk size parameter to compare_buffers()
>   qemu-img: rebase: avoid unnecessary COW operations
>   iotests/{024, 271}: add testcases for qemu-img rebase
>   qemu-img: add compression option to rebase subcommand
>   iotests: add tests for "qemu-img rebase" with compression

Thanks, applied to the block branch.

Kevin

Re: [PATCH v3 0/8] qemu-img: rebase: add compression support

Posted by Andrey Drobyshev 7 months ago

On 9/19/23 20:57, Andrey Drobyshev wrote:
> v2 --> v3:
>  * Patch 3/8: fixed logic in the if statement, so that we align on blk
>    when blk_old_backing == NULL;
>  * Patch 4/8: comment fix;
>  * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)"
>    statements.
> 
> v2: https://lists.nongnu.org/archive/html/qemu-block/2023-09/msg00448.html
> 
> Andrey Drobyshev (8):
>   qemu-img: rebase: stop when reaching EOF of old backing file
>   qemu-iotests: 024: add rebasing test case for overlay_size >
>     backing_size
>   qemu-img: rebase: use backing files' BlockBackend for buffer alignment
>   qemu-img: add chunk size parameter to compare_buffers()
>   qemu-img: rebase: avoid unnecessary COW operations
>   iotests/{024, 271}: add testcases for qemu-img rebase
>   qemu-img: add compression option to rebase subcommand
>   iotests: add tests for "qemu-img rebase" with compression
> 
>  docs/tools/qemu-img.rst    |   6 +-
>  qemu-img-cmds.hx           |   4 +-
>  qemu-img.c                 | 136 ++++++++++++++++++++++--------
>  tests/qemu-iotests/024     | 117 ++++++++++++++++++++++++++
>  tests/qemu-iotests/024.out |  73 ++++++++++++++++
>  tests/qemu-iotests/271     | 131 +++++++++++++++++++++++++++++
>  tests/qemu-iotests/271.out |  82 ++++++++++++++++++
>  tests/qemu-iotests/314     | 165 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/314.out |  75 +++++++++++++++++
>  9 files changed, 752 insertions(+), 37 deletions(-)
>  create mode 100755 tests/qemu-iotests/314
>  create mode 100644 tests/qemu-iotests/314.out
> 

Ping

Re: [PATCH v3 0/8] qemu-img: rebase: add compression support

Posted by Andrey Drobyshev 6 months, 2 weeks ago

On 10/2/23 09:35, Andrey Drobyshev wrote:
> On 9/19/23 20:57, Andrey Drobyshev wrote:
>> v2 --> v3:
>>  * Patch 3/8: fixed logic in the if statement, so that we align on blk
>>    when blk_old_backing == NULL;
>>  * Patch 4/8: comment fix;
>>  * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)"
>>    statements.
>>
>> v2: https://lists.nongnu.org/archive/html/qemu-block/2023-09/msg00448.html
>>
>> Andrey Drobyshev (8):
>>   qemu-img: rebase: stop when reaching EOF of old backing file
>>   qemu-iotests: 024: add rebasing test case for overlay_size >
>>     backing_size
>>   qemu-img: rebase: use backing files' BlockBackend for buffer alignment
>>   qemu-img: add chunk size parameter to compare_buffers()
>>   qemu-img: rebase: avoid unnecessary COW operations
>>   iotests/{024, 271}: add testcases for qemu-img rebase
>>   qemu-img: add compression option to rebase subcommand
>>   iotests: add tests for "qemu-img rebase" with compression
>>
>>  docs/tools/qemu-img.rst    |   6 +-
>>  qemu-img-cmds.hx           |   4 +-
>>  qemu-img.c                 | 136 ++++++++++++++++++++++--------
>>  tests/qemu-iotests/024     | 117 ++++++++++++++++++++++++++
>>  tests/qemu-iotests/024.out |  73 ++++++++++++++++
>>  tests/qemu-iotests/271     | 131 +++++++++++++++++++++++++++++
>>  tests/qemu-iotests/271.out |  82 ++++++++++++++++++
>>  tests/qemu-iotests/314     | 165 +++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/314.out |  75 +++++++++++++++++
>>  9 files changed, 752 insertions(+), 37 deletions(-)
>>  create mode 100755 tests/qemu-iotests/314
>>  create mode 100644 tests/qemu-iotests/314.out
>>
> 
> Ping

Friendly ping