[PATCH 1/4] accel/tcg: Remove tlb_set_dirty() stub

Philippe Mathieu-Daudé posted 4 patches 2 years, 4 months ago
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, "Alex Bennée" <alex.bennee@linaro.org>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Harsh Prateek Bora <harshpb@linux.ibm.com>
[PATCH 1/4] accel/tcg: Remove tlb_set_dirty() stub
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago
Since commit 34d49937e4 ("accel/tcg: Handle atomic accesses
to notdirty memory correctly") there is only a single call
to tlb_set_dirty(), within accel/tcg/cputlb.c itself where
the function is defined.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 accel/stubs/tcg-stub.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index a9e7a2d5b4..f088054f34 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -18,10 +18,6 @@ void tb_flush(CPUState *cpu)
 {
 }
 
-void tlb_set_dirty(CPUState *cpu, vaddr vaddr)
-{
-}
-
 void tcg_flush_jmp_cache(CPUState *cpu)
 {
 }
-- 
2.41.0


Re: [PATCH 1/4] accel/tcg: Remove tlb_set_dirty() stub
Posted by Harsh Prateek Bora 2 years, 4 months ago

On 9/15/23 01:22, Philippe Mathieu-Daudé wrote:
> Since commit 34d49937e4 ("accel/tcg: Handle atomic accesses
> to notdirty memory correctly") there is only a single call
> to tlb_set_dirty(), within accel/tcg/cputlb.c itself where
> the function is defined.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   accel/stubs/tcg-stub.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index a9e7a2d5b4..f088054f34 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -18,10 +18,6 @@ void tb_flush(CPUState *cpu)
>   {
>   }
>   
> -void tlb_set_dirty(CPUState *cpu, vaddr vaddr)
> -{
> -}
> -
>   void tcg_flush_jmp_cache(CPUState *cpu)
>   {
>   }