1. Patchew
  2. QEMU
  3. [PULL 00/51] Build system, i386 changes for 2023-09-07
  4. View patch

[PULL 50/51] subprojects: add wrap file for libblkio

Paolo Bonzini posted 51 patches 2 years, 5 months ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>, Stefan Weil <sw@weilnetz.de>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Beraldo Leal <bleal@redhat.com>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>, Markus Armbruster <armbru@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Juan Quintela <quintela@redhat.com>, Leonardo Bras <leobras@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
[PULL 50/51] subprojects: add wrap file for libblkio
Posted by Paolo Bonzini 2 years, 5 months ago 
This allows building libblkio at the same time as QEMU, if QEMU is
configured with --enable-blkio --enable-download.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 subprojects/libblkio.wrap | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 subprojects/libblkio.wrap

diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
new file mode 100644
index 00000000000..f77af72210c
--- /dev/null
+++ b/subprojects/libblkio.wrap
@@ -0,0 +1,6 @@
+[wrap-git]
+url = https://gitlab.com/libblkio/libblkio
+revision = f84cc963a444e4cb34813b2dcfc5bf8526947dc0
+
+[provide]
+blkio = libblkio_dep
-- 
2.41.0
Re: [PULL 50/51] subprojects: add wrap file for libblkio
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago 
Hi Paolo,

On 7/9/23 14:59, Paolo Bonzini wrote:
> This allows building libblkio at the same time as QEMU, if QEMU is
> configured with --enable-blkio --enable-download.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   subprojects/libblkio.wrap | 6 ++++++
>   1 file changed, 6 insertions(+)
>   create mode 100644 subprojects/libblkio.wrap
> 
> diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
> new file mode 100644
> index 00000000000..f77af72210c
> --- /dev/null
> +++ b/subprojects/libblkio.wrap
> @@ -0,0 +1,6 @@
> +[wrap-git]
> +url = https://gitlab.com/libblkio/libblkio

Tyler noticed this project isn't mirrored on QEMU gitlab namespace.

> +revision = f84cc963a444e4cb34813b2dcfc5bf8526947dc0
> +
> +[provide]
> +blkio = libblkio_dep
Re: [PULL 50/51] subprojects: add wrap file for libblkio
Posted by Daniel P. Berrangé 2 years, 4 months ago 
On Wed, Oct 11, 2023 at 07:35:24AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
> 
> On 7/9/23 14:59, Paolo Bonzini wrote:
> > This allows building libblkio at the same time as QEMU, if QEMU is
> > configured with --enable-blkio --enable-download.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   subprojects/libblkio.wrap | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >   create mode 100644 subprojects/libblkio.wrap
> > 
> > diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
> > new file mode 100644
> > index 00000000000..f77af72210c
> > --- /dev/null
> > +++ b/subprojects/libblkio.wrap
> > @@ -0,0 +1,6 @@
> > +[wrap-git]
> > +url = https://gitlab.com/libblkio/libblkio
> 
> Tyler noticed this project isn't mirrored on QEMU gitlab namespace.

Many other wraps aren't mirrored either, and I'm not convinced we
need to, unless the project is on an obscure self hosted git service
which is thought unreliable.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PULL 50/51] subprojects: add wrap file for libblkio
Posted by Stefan Hajnoczi 2 years, 4 months ago 
On Wed, 11 Oct 2023 at 04:48, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Wed, Oct 11, 2023 at 07:35:24AM +0200, Philippe Mathieu-Daudé wrote:
> > Hi Paolo,
> >
> > On 7/9/23 14:59, Paolo Bonzini wrote:
> > > This allows building libblkio at the same time as QEMU, if QEMU is
> > > configured with --enable-blkio --enable-download.
> > >
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > >   subprojects/libblkio.wrap | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >   create mode 100644 subprojects/libblkio.wrap
> > >
> > > diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
> > > new file mode 100644
> > > index 00000000000..f77af72210c
> > > --- /dev/null
> > > +++ b/subprojects/libblkio.wrap
> > > @@ -0,0 +1,6 @@
> > > +[wrap-git]
> > > +url = https://gitlab.com/libblkio/libblkio
> >
> > Tyler noticed this project isn't mirrored on QEMU gitlab namespace.
>
> Many other wraps aren't mirrored either, and I'm not convinced we
> need to, unless the project is on an obscure self hosted git service
> which is thought unreliable.

What if upstream deletes the repository or sets visibility to
"private"? Do GitHub and GitLab guarantee availability of previously
public repositories?

Stefan
Re: [PULL 50/51] subprojects: add wrap file for libblkio
Posted by Daniel P. Berrangé 2 years, 4 months ago 
On Wed, Oct 11, 2023 at 04:58:01PM -0400, Stefan Hajnoczi wrote:
> On Wed, 11 Oct 2023 at 04:48, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Oct 11, 2023 at 07:35:24AM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi Paolo,
> > >
> > > On 7/9/23 14:59, Paolo Bonzini wrote:
> > > > This allows building libblkio at the same time as QEMU, if QEMU is
> > > > configured with --enable-blkio --enable-download.
> > > >
> > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > > ---
> > > >   subprojects/libblkio.wrap | 6 ++++++
> > > >   1 file changed, 6 insertions(+)
> > > >   create mode 100644 subprojects/libblkio.wrap
> > > >
> > > > diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap
> > > > new file mode 100644
> > > > index 00000000000..f77af72210c
> > > > --- /dev/null
> > > > +++ b/subprojects/libblkio.wrap
> > > > @@ -0,0 +1,6 @@
> > > > +[wrap-git]
> > > > +url = https://gitlab.com/libblkio/libblkio
> > >
> > > Tyler noticed this project isn't mirrored on QEMU gitlab namespace.
> >
> > Many other wraps aren't mirrored either, and I'm not convinced we
> > need to, unless the project is on an obscure self hosted git service
> > which is thought unreliable.
> 
> What if upstream deletes the repository or sets visibility to
> "private"? Do GitHub and GitLab guarantee availability of previously
> public repositories?

No, there's no such guarantee. If it was a repo under a personal user
namespace mirroring is justified for this reason, but for a project
level namespace I feel we're protecting ourselves from a scenario
that's just never going to happen.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.