[PATCH 1/2] target/i386/hvf: Remove unused includes in 'hvf-i386.h'

Philippe Mathieu-Daudé posted 2 patches 2 years, 5 months ago
Maintainers: Cameron Esfahani <dirty@apple.com>, Roman Bolshakov <rbolshakov@ddn.com>
There is a newer version of this series
[PATCH 1/2] target/i386/hvf: Remove unused includes in 'hvf-i386.h'
Posted by Philippe Mathieu-Daudé 2 years, 5 months ago
The only non standard type -- CPUArchState -- is forward
declared in "qemu/typedefs.h", so no particular header is
required here.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/i386/hvf/hvf-i386.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/target/i386/hvf/hvf-i386.h b/target/i386/hvf/hvf-i386.h
index 95b47c1c2e..243bc111cc 100644
--- a/target/i386/hvf/hvf-i386.h
+++ b/target/i386/hvf/hvf-i386.h
@@ -16,12 +16,6 @@
 #ifndef HVF_I386_H
 #define HVF_I386_H
 
-#include "qemu/accel.h"
-#include "sysemu/hvf.h"
-#include "sysemu/hvf_int.h"
-#include "cpu.h"
-#include "x86.h"
-
 void hvf_handle_io(CPUArchState *, uint16_t, void *, int, int, int);
 
 /* Host specific functions */
-- 
2.41.0


Re: [PATCH 1/2] target/i386/hvf: Remove unused includes in 'hvf-i386.h'
Posted by Roman Bolshakov 2 years, 5 months ago
On Tue, Sep 05, 2023 at 02:39:05PM +0200, Philippe Mathieu-Daudé wrote:
> The only non standard type -- CPUArchState -- is forward
> declared in "qemu/typedefs.h", so no particular header is
> required here.
> 

Hi Philippe,

Reviewed-by: Roman Bolshakov <roman@roolebo.dev>
Tested-by: Roman Bolshakov <roman@roolebo.dev>

Regards,
Roman