[v1] aspeed queue

[PULL 00/26] aspeed queue

Posted by Cédric Le Goater 8 months ago

The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc:

  Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-31 10:06:29 -0400)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-aspeed-20230901

for you to fetch changes up to c3287c0f70dae07dd12322c5c8663f7b878826e7:

  hw/sd: Introduce a "sd-card" SPI variant model (2023-09-01 11:40:04 +0200)

----------------------------------------------------------------
aspeed queue:

* Fixes for the Aspeed I2C model
* New SDK image for avocado tests
* blockdev support for flash device definition
* SD refactoring preparing ground for eMMC support

----------------------------------------------------------------
Cédric Le Goater (10):
      aspeed: Introduce helper for 32-bit hosts limitation
      tests/avocado/machine_aspeed.py: Update SDK images
      hw/ssi: Add a "cs" property to SSIPeripheral
      hw/ssi: Introduce a ssi_get_cs() helper
      aspeed/smc: Wire CS lines at reset
      hw/ssi: Check for duplicate CS indexes
      aspeed: Create flash devices only when defaults are enabled
      m25p80: Introduce an helper to retrieve the BlockBackend of a device
      aspeed: Get the BlockBackend of FMC0 from the flash device
      hw/sd: Introduce a "sd-card" SPI variant model

Hang Yu (3):
      hw/i2c/aspeed: Fix Tx count and Rx size error in buffer pool mode
      hw/i2c/aspeed: Fix TXBUF transmission start position error
      hw/i2c/aspeed: Add support for buffer organization

Joel Stanley (1):
      hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler

Philippe Mathieu-Daudé (12):
      hw/sd/sdcard: Return ILLEGAL for CMD19/CMD23 prior SD spec v3.01
      hw/sd: When card is in wrong state, log which state it is
      hw/sd: When card is in wrong state, log which spec version is used
      hw/sd: Move proto_name to SDProto structure
      hw/sd: Introduce sd_cmd_handler type
      hw/sd: Add sd_cmd_illegal() handler
      hw/sd: Add sd_cmd_unimplemented() handler
      hw/sd: Add sd_cmd_GO_IDLE_STATE() handler
      hw/sd: Add sd_cmd_SEND_OP_CMD() handler
      hw/sd: Add sd_cmd_ALL_SEND_CID() handler
      hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler
      hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler

 docs/system/arm/aspeed.rst          |  35 +++-
 include/hw/block/flash.h            |   4 +
 include/hw/i2c/aspeed_i2c.h         |   5 +-
 include/hw/sd/sd.h                  |   5 +
 include/hw/ssi/ssi.h                |   5 +
 hw/arm/aspeed.c                     |  40 ++---
 hw/arm/stellaris.c                  |   7 +-
 hw/arm/xilinx_zynq.c                |   1 +
 hw/arm/xlnx-versal-virt.c           |   1 +
 hw/arm/xlnx-zcu102.c                |   2 +
 hw/block/m25p80.c                   |   6 +
 hw/i2c/aspeed_i2c.c                 |  40 ++---
 hw/microblaze/petalogix_ml605_mmu.c |   1 +
 hw/riscv/sifive_u.c                 |   3 +-
 hw/sd/sd.c                          | 348 ++++++++++++++++++++++--------------
 hw/sd/sdmmc-internal.c              |   2 +-
 hw/ssi/aspeed_smc.c                 |   8 +
 hw/ssi/ssi.c                        |  43 +++++
 tests/avocado/machine_aspeed.py     |  12 +-
 19 files changed, 367 insertions(+), 201 deletions(-)

Re: [PULL 00/26] aspeed queue

Posted by Stefan Hajnoczi 7 months, 3 weeks ago

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes.

Re: [PULL 00/26] aspeed queue

Posted by Cédric Le Goater 7 months, 3 weeks ago

On 9/1/23 11:41, Cédric Le Goater wrote:
> The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc:
> 
>    Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-31 10:06:29 -0400)
> 
> are available in the Git repository at:
> 
>    https://github.com/legoater/qemu/ tags/pull-aspeed-20230901
> 
> for you to fetch changes up to c3287c0f70dae07dd12322c5c8663f7b878826e7:
> 
>    hw/sd: Introduce a "sd-card" SPI variant model (2023-09-01 11:40:04 +0200)
> 
> ----------------------------------------------------------------
> aspeed queue:
> 
> * Fixes for the Aspeed I2C model
> * New SDK image for avocado tests
> * blockdev support for flash device definition
> * SD refactoring preparing ground for eMMC support
> 
> ----------------------------------------------------------------
> Cédric Le Goater (10):
>        aspeed: Introduce helper for 32-bit hosts limitation
>        tests/avocado/machine_aspeed.py: Update SDK images
>        hw/ssi: Add a "cs" property to SSIPeripheral
>        hw/ssi: Introduce a ssi_get_cs() helper
>        aspeed/smc: Wire CS lines at reset
>        hw/ssi: Check for duplicate CS indexes
>        aspeed: Create flash devices only when defaults are enabled
>        m25p80: Introduce an helper to retrieve the BlockBackend of a device
>        aspeed: Get the BlockBackend of FMC0 from the flash device
>        hw/sd: Introduce a "sd-card" SPI variant model
> 
> Hang Yu (3):
>        hw/i2c/aspeed: Fix Tx count and Rx size error in buffer pool mode
>        hw/i2c/aspeed: Fix TXBUF transmission start position error

Michael,

I think the two above are candidates for stable.

Thanks,

C.


>        hw/i2c/aspeed: Add support for buffer organization
> 
> Joel Stanley (1):
>        hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler
> 
> Philippe Mathieu-Daudé (12):
>        hw/sd/sdcard: Return ILLEGAL for CMD19/CMD23 prior SD spec v3.01
>        hw/sd: When card is in wrong state, log which state it is
>        hw/sd: When card is in wrong state, log which spec version is used
>        hw/sd: Move proto_name to SDProto structure
>        hw/sd: Introduce sd_cmd_handler type
>        hw/sd: Add sd_cmd_illegal() handler
>        hw/sd: Add sd_cmd_unimplemented() handler
>        hw/sd: Add sd_cmd_GO_IDLE_STATE() handler
>        hw/sd: Add sd_cmd_SEND_OP_CMD() handler
>        hw/sd: Add sd_cmd_ALL_SEND_CID() handler
>        hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler
>        hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler
> 
>   docs/system/arm/aspeed.rst          |  35 +++-
>   include/hw/block/flash.h            |   4 +
>   include/hw/i2c/aspeed_i2c.h         |   5 +-
>   include/hw/sd/sd.h                  |   5 +
>   include/hw/ssi/ssi.h                |   5 +
>   hw/arm/aspeed.c                     |  40 ++---
>   hw/arm/stellaris.c                  |   7 +-
>   hw/arm/xilinx_zynq.c                |   1 +
>   hw/arm/xlnx-versal-virt.c           |   1 +
>   hw/arm/xlnx-zcu102.c                |   2 +
>   hw/block/m25p80.c                   |   6 +
>   hw/i2c/aspeed_i2c.c                 |  40 ++---
>   hw/microblaze/petalogix_ml605_mmu.c |   1 +
>   hw/riscv/sifive_u.c                 |   3 +-
>   hw/sd/sd.c                          | 348 ++++++++++++++++++++++--------------
>   hw/sd/sdmmc-internal.c              |   2 +-
>   hw/ssi/aspeed_smc.c                 |   8 +
>   hw/ssi/ssi.c                        |  43 +++++
>   tests/avocado/machine_aspeed.py     |  12 +-
>   19 files changed, 367 insertions(+), 201 deletions(-)

Re: [PULL 00/26] aspeed queue

Posted by Michael Tokarev 7 months, 3 weeks ago

08.09.2023 10:09, Cédric Le Goater wrote:
..
>> Hang Yu (3):
>>        hw/i2c/aspeed: Fix Tx count and Rx size error in buffer pool mode
>>        hw/i2c/aspeed: Fix TXBUF transmission start position error
> 
> Michael,
> 
> I think the two above are candidates for stable.

Got it.  I've noticed these two in master yesterday, but thought
i2c/aspeed priority is a bit lower than other stuff, - maybe
wrongly.

Picked these two up now.

Thank you for making me know!

/mjt

Re: [PULL 00/26] aspeed queue

Posted by Cédric Le Goater 7 months, 3 weeks ago

On 9/8/23 09:52, Michael Tokarev wrote:
> 08.09.2023 10:09, Cédric Le Goater wrote:
> ..
>>> Hang Yu (3):
>>>        hw/i2c/aspeed: Fix Tx count and Rx size error in buffer pool mode
>>>        hw/i2c/aspeed: Fix TXBUF transmission start position error
>>
>> Michael,
>>
>> I think the two above are candidates for stable.
> 
> Got it.  I've noticed these two in master yesterday, but thought
> i2c/aspeed priority is a bit lower than other stuff, - maybe
> wrongly.

It is not hot material indeed but it does fix support for the
latest Aspeed SDK and a lot people simply use the disto QEMU.

> Picked these two up now.

Thanks, !

C.