1. Patchew
  2. QEMU
  3. View series

[PULL 00/14] Block patches

Hanna Czenczek posted 14 patches 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230901081804.31377-1-hreitz@redhat.com
Maintainers: "Gonglei (Arei)" <arei.gonglei@huawei.com>, Zhenwei Pi <pizhenwei@bytedance.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Alberto Garcia <berto@igalia.com>, Greg Kurz <groug@kaod.org>, Christian Schoenebeck <qemu_oss@crudebyte.com>
There is a newer version of this series
fsdev/qemu-fsdev-throttle.h                |   4 +-
include/block/throttle-groups.h            |   6 +-
include/qemu/throttle.h                    |  16 +-
backends/cryptodev.c                       |  12 +-
block/block-backend.c                      |   4 +-
block/file-posix.c                         |  42 +++---
block/throttle-groups.c                    | 163 +++++++++++----------
block/throttle.c                           |   8 +-
fsdev/qemu-fsdev-throttle.c                |  18 ++-
hw/9pfs/cofile.c                           |   4 +-
tests/unit/test-throttle.c                 |  76 +++++++++-
util/throttle.c                            |  84 +++++++----
tests/qemu-iotests/tests/file-io-error     | 119 +++++++++++++++
tests/qemu-iotests/tests/file-io-error.out |  33 +++++
14 files changed, 418 insertions(+), 171 deletions(-)
create mode 100755 tests/qemu-iotests/tests/file-io-error
create mode 100644 tests/qemu-iotests/tests/file-io-error.out
[PULL 00/14] Block patches
Posted by Hanna Czenczek 8 months ago 
The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:

  Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 -0400)

are available in the Git repository at:

  https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01

for you to fetch changes up to 380448464dd89291cf7fd7434be6c225482a334d:

  tests/file-io-error: New test (2023-08-29 13:01:24 +0200)

----------------------------------------------------------------
Block patches

- Fix for file-posix's zoning code crashing on I/O errors
- Throttling refactoring

----------------------------------------------------------------
Hanna Czenczek (5):
  file-posix: Clear bs->bl.zoned on error
  file-posix: Check bs->bl.zoned for zone info
  file-posix: Fix zone update in I/O error path
  file-posix: Simplify raw_co_prw's 'out' zone code
  tests/file-io-error: New test

Zhenwei Pi (9):
  throttle: introduce enum ThrottleDirection
  test-throttle: use enum ThrottleDirection
  throttle: support read-only and write-only
  test-throttle: test read only and write only
  cryptodev: use NULL throttle timer cb for read direction
  throttle: use enum ThrottleDirection instead of bool is_write
  throttle: use THROTTLE_MAX/ARRAY_SIZE for hard code
  fsdev: Use ThrottleDirection instread of bool is_write
  block/throttle-groups: Use ThrottleDirection instread of bool is_write

 fsdev/qemu-fsdev-throttle.h                |   4 +-
 include/block/throttle-groups.h            |   6 +-
 include/qemu/throttle.h                    |  16 +-
 backends/cryptodev.c                       |  12 +-
 block/block-backend.c                      |   4 +-
 block/file-posix.c                         |  42 +++---
 block/throttle-groups.c                    | 163 +++++++++++----------
 block/throttle.c                           |   8 +-
 fsdev/qemu-fsdev-throttle.c                |  18 ++-
 hw/9pfs/cofile.c                           |   4 +-
 tests/unit/test-throttle.c                 |  76 +++++++++-
 util/throttle.c                            |  84 +++++++----
 tests/qemu-iotests/tests/file-io-error     | 119 +++++++++++++++
 tests/qemu-iotests/tests/file-io-error.out |  33 +++++
 14 files changed, 418 insertions(+), 171 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/file-io-error
 create mode 100644 tests/qemu-iotests/tests/file-io-error.out

-- 
2.41.0
Re: [PULL 00/14] Block patches
Posted by Stefan Hajnoczi 7 months, 3 weeks ago 
On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek <hreitz@redhat.com> wrote:
>
> The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
>
>   Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01

Hi Hanna,
Please push a signed tag (git tag -s). Thanks!

Stefan

>
> for you to fetch changes up to 380448464dd89291cf7fd7434be6c225482a334d:
>
>   tests/file-io-error: New test (2023-08-29 13:01:24 +0200)
>
> ----------------------------------------------------------------
> Block patches
>
> - Fix for file-posix's zoning code crashing on I/O errors
> - Throttling refactoring
>
> ----------------------------------------------------------------
> Hanna Czenczek (5):
>   file-posix: Clear bs->bl.zoned on error
>   file-posix: Check bs->bl.zoned for zone info
>   file-posix: Fix zone update in I/O error path
>   file-posix: Simplify raw_co_prw's 'out' zone code
>   tests/file-io-error: New test
>
> Zhenwei Pi (9):
>   throttle: introduce enum ThrottleDirection
>   test-throttle: use enum ThrottleDirection
>   throttle: support read-only and write-only
>   test-throttle: test read only and write only
>   cryptodev: use NULL throttle timer cb for read direction
>   throttle: use enum ThrottleDirection instead of bool is_write
>   throttle: use THROTTLE_MAX/ARRAY_SIZE for hard code
>   fsdev: Use ThrottleDirection instread of bool is_write
>   block/throttle-groups: Use ThrottleDirection instread of bool is_write
>
>  fsdev/qemu-fsdev-throttle.h                |   4 +-
>  include/block/throttle-groups.h            |   6 +-
>  include/qemu/throttle.h                    |  16 +-
>  backends/cryptodev.c                       |  12 +-
>  block/block-backend.c                      |   4 +-
>  block/file-posix.c                         |  42 +++---
>  block/throttle-groups.c                    | 163 +++++++++++----------
>  block/throttle.c                           |   8 +-
>  fsdev/qemu-fsdev-throttle.c                |  18 ++-
>  hw/9pfs/cofile.c                           |   4 +-
>  tests/unit/test-throttle.c                 |  76 +++++++++-
>  util/throttle.c                            |  84 +++++++----
>  tests/qemu-iotests/tests/file-io-error     | 119 +++++++++++++++
>  tests/qemu-iotests/tests/file-io-error.out |  33 +++++
>  14 files changed, 418 insertions(+), 171 deletions(-)
>  create mode 100755 tests/qemu-iotests/tests/file-io-error
>  create mode 100644 tests/qemu-iotests/tests/file-io-error.out
>
> --
> 2.41.0
>
>
Re: [PULL 00/14] Block patches
Posted by Hanna Czenczek 7 months, 3 weeks ago 
On 06.09.23 15:18, Stefan Hajnoczi wrote:
> On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek <hreitz@redhat.com> wrote:
>> The following changes since commit f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
>>
>>    Merge tag 'pull-tcg-20230823-2' of https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 -0400)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01
> Hi Hanna,
> Please push a signed tag (git tag -s). Thanks!

Is it not signed?  I don’t think gitlab has support to show that, but 
github shows it as verified: 
https://github.com/XanClic/qemu/releases/tag/pull-block-2023-09-01

And when I clone it:
```
$ git clone https://gitlab.com/hreitz/qemu -b pull-block-2023-09-01 
--depth=1
[...]
$ cd qemu
$ git tag -v pull-block-2023-09-01
LANG=C git tag -v pull-block-2023-09-01
object 380448464dd89291cf7fd7434be6c225482a334d
type commit
tag pull-block-2023-09-01
tagger Hanna Reitz <hreitz@redhat.com> 1693555853 +0200

Block patches

- Fix for file-posix's zoning code crashing on I/O errors
- Throttling refactoring
gpg: Signature made Fri Sep  1 10:11:46 2023 CEST
gpg:                using RSA key CB62D7A0EE3829E45F004D34A1FA40D098019CDF
gpg:                issuer "hreitz@redhat.com"
gpg: Good signature from "Hanna Reitz <hreitz@redhat.com>" [ultimate]
Primary key fingerprint: CB62 D7A0 EE38 29E4 5F00  4D34 A1FA 40D0 9801 9CDF
```

Hanna
Re: [PULL 00/14] Block patches
Posted by Hanna Czenczek 7 months, 2 weeks ago 
On 07.09.23 13:21, Hanna Czenczek wrote:
> On 06.09.23 15:18, Stefan Hajnoczi wrote:
>> On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek <hreitz@redhat.com> wrote:
>>> The following changes since commit 
>>> f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
>>>
>>>    Merge tag 'pull-tcg-20230823-2' of 
>>> https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 
>>> -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01
>> Hi Hanna,
>> Please push a signed tag (git tag -s). Thanks!

By the way, I meant to imply that I’m not going to push a new tag at 
this time.

I have generated this pull request as I always do, using a script that 
automatically signs the tag.  gpg asked me to enter my key password, 
indicating something had been signed, and the methods I know of tell me 
that the tag is indeed signed.  So as far as I can tell, the tag is 
signed as usual.  If I were to create a new pull request, I would do it 
the exact same way, which I expect would yield the same result, so we’d 
have the same problem again.

To get a different result, I need to know how you determine the tag not 
to be signed, so I can reproduce it and potentially fix the problem in 
my workflow.

Hanna

> Is it not signed?  I don’t think gitlab has support to show that, but 
> github shows it as verified: 
> https://github.com/XanClic/qemu/releases/tag/pull-block-2023-09-01
>
> And when I clone it:
> ```
> $ git clone https://gitlab.com/hreitz/qemu -b pull-block-2023-09-01 
> --depth=1
> [...]
> $ cd qemu
> $ git tag -v pull-block-2023-09-01
> LANG=C git tag -v pull-block-2023-09-01
> object 380448464dd89291cf7fd7434be6c225482a334d
> type commit
> tag pull-block-2023-09-01
> tagger Hanna Reitz <hreitz@redhat.com> 1693555853 +0200
>
> Block patches
>
> - Fix for file-posix's zoning code crashing on I/O errors
> - Throttling refactoring
> gpg: Signature made Fri Sep  1 10:11:46 2023 CEST
> gpg:                using RSA key 
> CB62D7A0EE3829E45F004D34A1FA40D098019CDF
> gpg:                issuer "hreitz@redhat.com"
> gpg: Good signature from "Hanna Reitz <hreitz@redhat.com>" [ultimate]
> Primary key fingerprint: CB62 D7A0 EE38 29E4 5F00  4D34 A1FA 40D0 9801 
> 9CDF
> ```
>
> Hanna

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.