kconfig: Add NVME to s390x machines

[PATCH] kconfig: Add NVME to s390x machines

Cédric Le Goater posted 1 patch 1 year, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230828150148.120031-1-clg@kaod.org

Maintainers: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>

hw/nvme/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] kconfig: Add NVME to s390x machines

Posted by Cédric Le Goater 1 year, 3 months ago

From: Cédric Le Goater <clg@redhat.com>

We recently had issues with nvme devices on big endian platforms.
Include their compilation on s390x to ease tests.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/nvme/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
index 8ac90942e55e..cfa2ab0f9d5a 100644
--- a/hw/nvme/Kconfig
+++ b/hw/nvme/Kconfig
@@ -1,4 +1,4 @@
 config NVME_PCI
     bool
-    default y if PCI_DEVICES
+    default y if PCI_DEVICES || PCIE_DEVICES
     depends on PCI
-- 
2.41.0

Re: [PATCH] kconfig: Add NVME to s390x machines

Posted by Klaus Jensen 1 year, 3 months ago

On Aug 28 17:01, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
> 
> We recently had issues with nvme devices on big endian platforms.
> Include their compilation on s390x to ease tests.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>  hw/nvme/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index 8ac90942e55e..cfa2ab0f9d5a 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -1,4 +1,4 @@
>  config NVME_PCI
>      bool
> -    default y if PCI_DEVICES
> +    default y if PCI_DEVICES || PCIE_DEVICES
>      depends on PCI
> -- 
> 2.41.0
> 

Acked-by: Klaus Jensen <k.jensen@samsung.com>

Re: [PATCH] kconfig: Add NVME to s390x machines

Posted by Thomas Huth 1 year, 3 months ago

On 28/08/2023 17.01, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
> 
> We recently had issues with nvme devices on big endian platforms.
> Include their compilation on s390x to ease tests.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/nvme/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index 8ac90942e55e..cfa2ab0f9d5a 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -1,4 +1,4 @@
>   config NVME_PCI
>       bool
> -    default y if PCI_DEVICES
> +    default y if PCI_DEVICES || PCIE_DEVICES
>       depends on PCI

hw/nvme/ctrl.c uses INTERFACE_PCIE_DEVICE, so I think looks right to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>