[v1] io: follow coroutine AioContext in qio_channel_yield()

[PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()

Stefan Hajnoczi posted 2 patches 1 year, 3 months ago

Diff against v2 v3
Download mbox

Maintainers: Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Coiby Xu <Coiby.Xu@gmail.com>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>

There is a newer version of this series

Expand all Fold all

[PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()

Posted by Stefan Hajnoczi 1 year, 3 months ago

Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.

This patch is preparation for the fd handler changes that follow.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 io/channel.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/io/channel.c b/io/channel.c
index 72f0066af5..c415f3fc88 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -653,6 +653,10 @@ static void qio_channel_finalize(Object *obj)
 {
     QIOChannel *ioc = QIO_CHANNEL(obj);
 
+    /* Must not have coroutines in qio_channel_yield() */
+    assert(!ioc->read_coroutine);
+    assert(!ioc->write_coroutine);
+
     g_free(ioc->name);
 
 #ifdef _WIN32
-- 
2.41.0

Re: [PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()

Posted by Eric Blake 1 year, 3 months ago

On Wed, Aug 23, 2023 at 07:45:03PM -0400, Stefan Hajnoczi wrote:
> Callers must clean up their coroutines before calling
> object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
> assertion to check this.
> 
> This patch is preparation for the fd handler changes that follow.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  io/channel.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org

Re: [PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()

Posted by Daniel P. Berrangé 1 year, 3 months ago

On Wed, Aug 23, 2023 at 07:45:03PM -0400, Stefan Hajnoczi wrote:
> Callers must clean up their coroutines before calling
> object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
> assertion to check this.
> 
> This patch is preparation for the fd handler changes that follow.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  io/channel.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()
[PATCH 2/2] io: follow coroutine AioContext in qio_channel_yield()