1. Patchew
  2. QEMU
  3. View series

[PULL 00/12] First batch of s390x patches for QEMU 8.2

Thomas Huth posted 12 patches 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230823114544.216520-1-thuth@redhat.com
Maintainers: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Laurent Vivier <laurent@vivier.eu>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>
include/hw/boards.h                  |  3 ++
include/hw/i386/pc.h                 |  3 ++
include/hw/virtio/virtio-gpu-bswap.h |  3 ++
hw/arm/virt.c                        |  9 +++-
hw/core/machine.c                    |  3 ++
hw/i386/pc.c                         |  3 ++
hw/i386/pc_piix.c                    | 16 +++++--
hw/i386/pc_q35.c                     | 14 +++++-
hw/m68k/virt.c                       |  9 +++-
hw/ppc/spapr.c                       | 15 +++++-
hw/s390x/s390-pci-bus.c              | 25 ++++------
hw/s390x/s390-pci-inst.c             | 48 ++++++++------------
hw/s390x/s390-virtio-ccw.c           | 18 ++++++--
linux-user/elfload.c                 |  1 +
target/s390x/kvm/kvm.c               | 33 +++++---------
target/s390x/tcg/vec_helper.c        |  2 +-
target/s390x/tcg/vec_string_helper.c | 54 +++++++---------------
tests/tcg/s390x/vrep.c               | 81 +++++++++++++++++++++++++++++++++
tests/tcg/s390x/vstl.c               | 37 +++++++++++++++
tests/tcg/s390x/vxeh2_vstrs.c        | 88 ++++++++++++++++++++++++++++++++++++
target/s390x/tcg/translate_vx.c.inc  |  6 +--
hw/s390x/trace-events                | 17 +++++++
target/s390x/kvm/trace-events        |  7 +++
tests/tcg/s390x/Makefile.target      |  3 ++
24 files changed, 375 insertions(+), 123 deletions(-)
create mode 100644 tests/tcg/s390x/vrep.c
create mode 100644 tests/tcg/s390x/vstl.c
create mode 100644 tests/tcg/s390x/vxeh2_vstrs.c
[PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Thomas Huth 1 year, 3 months ago 
The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:

  Open 8.2 development tree (2023-08-22 07:14:07 -0700)

are available in the Git repository at:

  https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23

for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:

  tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)

----------------------------------------------------------------
* Add compat machines for QEMU 8.2
* Convert some DPRINTFs in s390x code into trace events
* Fix VFMIN/VFMAX, VSTL, VREP and VSTRS s390x instructions
* Fix virtio-gpu on big endian (i.e. s390x) hosts

----------------------------------------------------------------
Cornelia Huck (1):
      hw: Add compat machines for 8.2

Cédric Le Goater (1):
      s390x: Convert DPRINTF to trace events

Ilya Leoshkevich (8):
      target/s390x: Check reserved bits of VFMIN/VFMAX's M5
      target/s390x: Fix VSTL with a large length
      tests/tcg/s390x: Test VSTL
      target/s390x: Use a 16-bit immediate in VREP
      tests/tcg/s390x: Test VREP
      linux-user/elfload: Enable vxe2 on s390x
      target/s390x: Fix the "ignored match" case in VSTRS
      tests/tcg/s390x: Test VSTRS

Thomas Huth (2):
      hw/s390x/s390-virtio-ccw: Remove superfluous code to set the NIC model
      include/hw/virtio/virtio-gpu: Fix virtio-gpu with blob on big endian hosts

 include/hw/boards.h                  |  3 ++
 include/hw/i386/pc.h                 |  3 ++
 include/hw/virtio/virtio-gpu-bswap.h |  3 ++
 hw/arm/virt.c                        |  9 +++-
 hw/core/machine.c                    |  3 ++
 hw/i386/pc.c                         |  3 ++
 hw/i386/pc_piix.c                    | 16 +++++--
 hw/i386/pc_q35.c                     | 14 +++++-
 hw/m68k/virt.c                       |  9 +++-
 hw/ppc/spapr.c                       | 15 +++++-
 hw/s390x/s390-pci-bus.c              | 25 ++++------
 hw/s390x/s390-pci-inst.c             | 48 ++++++++------------
 hw/s390x/s390-virtio-ccw.c           | 18 ++++++--
 linux-user/elfload.c                 |  1 +
 target/s390x/kvm/kvm.c               | 33 +++++---------
 target/s390x/tcg/vec_helper.c        |  2 +-
 target/s390x/tcg/vec_string_helper.c | 54 +++++++---------------
 tests/tcg/s390x/vrep.c               | 81 +++++++++++++++++++++++++++++++++
 tests/tcg/s390x/vstl.c               | 37 +++++++++++++++
 tests/tcg/s390x/vxeh2_vstrs.c        | 88 ++++++++++++++++++++++++++++++++++++
 target/s390x/tcg/translate_vx.c.inc  |  6 +--
 hw/s390x/trace-events                | 17 +++++++
 target/s390x/kvm/trace-events        |  7 +++
 tests/tcg/s390x/Makefile.target      |  3 ++
 24 files changed, 375 insertions(+), 123 deletions(-)
 create mode 100644 tests/tcg/s390x/vrep.c
 create mode 100644 tests/tcg/s390x/vstl.c
 create mode 100644 tests/tcg/s390x/vxeh2_vstrs.c
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Stefan Hajnoczi 1 year, 3 months ago 
On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
> The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
> 
>   Open 8.2 development tree (2023-08-22 07:14:07 -0700)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
> 
> for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:
> 
>   tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)

Hi Thomas,
Please take a look at the following ubuntu-20.04-s390x-all CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/4931341536

Stefan
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Thomas Huth 1 year, 3 months ago 
On 23/08/2023 18.34, Stefan Hajnoczi wrote:
> On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
>> The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
>>
>>    Open 8.2 development tree (2023-08-22 07:14:07 -0700)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
>>
>> for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:
>>
>>    tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)
> 
> Hi Thomas,
> Please take a look at the following ubuntu-20.04-s390x-all CI failure:
> https://gitlab.com/qemu-project/qemu/-/jobs/4931341536

It says: "TimeoutError: Timeout waiting for job to pause" ... could you 
please check the load on that host? ... I think that s390x runner is known 
for being too slow some times, so I assume that problem should go away if 
you re-run the job when it is less loaded.

  Thomas
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Stefan Hajnoczi 1 year, 3 months ago 
On Thu, 24 Aug 2023 at 02:53, Thomas Huth <thuth@redhat.com> wrote:
>
> On 23/08/2023 18.34, Stefan Hajnoczi wrote:
> > On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
> >> The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
> >>
> >>    Open 8.2 development tree (2023-08-22 07:14:07 -0700)
> >>
> >> are available in the Git repository at:
> >>
> >>    https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
> >>
> >> for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:
> >>
> >>    tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)
> >
> > Hi Thomas,
> > Please take a look at the following ubuntu-20.04-s390x-all CI failure:
> > https://gitlab.com/qemu-project/qemu/-/jobs/4931341536
>
> It says: "TimeoutError: Timeout waiting for job to pause" ... could you
> please check the load on that host? ... I think that s390x runner is known
> for being too slow some times, so I assume that problem should go away if
> you re-run the job when it is less loaded.

I ran it again and it timed out. I've merged the PR and assume the
test is just flaky.

Stefan
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Thomas Huth 1 year, 3 months ago 
On 24/08/2023 16.51, Stefan Hajnoczi wrote:
> On Thu, 24 Aug 2023 at 02:53, Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 23/08/2023 18.34, Stefan Hajnoczi wrote:
>>> On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
>>>> The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
>>>>
>>>>     Open 8.2 development tree (2023-08-22 07:14:07 -0700)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>     https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
>>>>
>>>> for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:
>>>>
>>>>     tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)
>>>
>>> Hi Thomas,
>>> Please take a look at the following ubuntu-20.04-s390x-all CI failure:
>>> https://gitlab.com/qemu-project/qemu/-/jobs/4931341536
>>
>> It says: "TimeoutError: Timeout waiting for job to pause" ... could you
>> please check the load on that host? ... I think that s390x runner is known
>> for being too slow some times, so I assume that problem should go away if
>> you re-run the job when it is less loaded.
> 
> I ran it again and it timed out. I've merged the PR and assume the
> test is just flaky.

I think someone needs to look at the runner to see whether there is still 
old stuff taking CPU time or something similar.

At least the two issues that occurred with the initial run ( 
qtest-i386/migration-test and io-qcow2-041) didn't reproduce in the follow 
up run here:

  https://gitlab.com/qemu-project/qemu/-/pipelines/979072973

(the ahci-test was failing instead)

  Thomas
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Philippe Mathieu-Daudé 1 year, 3 months ago 
On 24/8/23 18:10, Thomas Huth wrote:
> On 24/08/2023 16.51, Stefan Hajnoczi wrote:
>> On Thu, 24 Aug 2023 at 02:53, Thomas Huth <thuth@redhat.com> wrote:
>>>
>>> On 23/08/2023 18.34, Stefan Hajnoczi wrote:
>>>> On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
>>>>> The following changes since commit 
>>>>> b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
>>>>>
>>>>>     Open 8.2 development tree (2023-08-22 07:14:07 -0700)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
>>>>>
>>>>> for you to fetch changes up to 
>>>>> 6c49f685d30ffe81cfa47da2c258904ad28ac368:
>>>>>
>>>>>     tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)
>>>>
>>>> Hi Thomas,
>>>> Please take a look at the following ubuntu-20.04-s390x-all CI failure:
>>>> https://gitlab.com/qemu-project/qemu/-/jobs/4931341536
>>>
>>> It says: "TimeoutError: Timeout waiting for job to pause" ... could you
>>> please check the load on that host? ... I think that s390x runner is 
>>> known
>>> for being too slow some times, so I assume that problem should go 
>>> away if
>>> you re-run the job when it is less loaded.
>>
>> I ran it again and it timed out. I've merged the PR and assume the
>> test is just flaky.
> 
> I think someone needs to look at the runner to see whether there is 
> still old stuff taking CPU time or something similar.

Would reporting the runner load on failure help in some way?
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Peter Maydell 1 year, 3 months ago 
On Thu, 24 Aug 2023 at 17:10, Thomas Huth <thuth@redhat.com> wrote:
>
> On 24/08/2023 16.51, Stefan Hajnoczi wrote:
> > On Thu, 24 Aug 2023 at 02:53, Thomas Huth <thuth@redhat.com> wrote:
> >>
> >> On 23/08/2023 18.34, Stefan Hajnoczi wrote:
> >>> On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote:
> >>>> The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa:
> >>>>
> >>>>     Open 8.2 development tree (2023-08-22 07:14:07 -0700)
> >>>>
> >>>> are available in the Git repository at:
> >>>>
> >>>>     https://gitlab.com/thuth/qemu.git tags/pull-request-2023-08-23
> >>>>
> >>>> for you to fetch changes up to 6c49f685d30ffe81cfa47da2c258904ad28ac368:
> >>>>
> >>>>     tests/tcg/s390x: Test VSTRS (2023-08-23 12:07:30 +0200)
> >>>
> >>> Hi Thomas,
> >>> Please take a look at the following ubuntu-20.04-s390x-all CI failure:
> >>> https://gitlab.com/qemu-project/qemu/-/jobs/4931341536
> >>
> >> It says: "TimeoutError: Timeout waiting for job to pause" ... could you
> >> please check the load on that host? ... I think that s390x runner is known
> >> for being too slow some times, so I assume that problem should go away if
> >> you re-run the job when it is less loaded.
> >
> > I ran it again and it timed out. I've merged the PR and assume the
> > test is just flaky.
>
> I think someone needs to look at the runner to see whether there is still
> old stuff taking CPU time or something similar.

It does not currently seem to be running anything it should
not be. The uptime is less than 2 days so it was rebooted
recently.

thanks
-- PMM
Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2
Posted by Stefan Hajnoczi 1 year, 3 months ago 
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes.

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.