[v4] simpletrace: refactor and general improvements

[PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

Posted by Mads Ynddal 1 year, 3 months ago

From: Mads Ynddal <m.ynddal@samsung.com>

In my work to refactor simpletrace.py, I noticed that there's no
maintainer of it, and has the status of "odd fixes". I'm using it from
time to time, so I'd like to maintain the script.

I've added myself as reviewer under "Tracing" to be informed of changes
that might affect simpletrace.py.

Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6111b6b4d9..2ffb608dec 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3162,6 +3162,7 @@ F: stubs/
 
 Tracing
 M: Stefan Hajnoczi <stefanha@redhat.com>
+R: Mads Ynddal <mads@ynddal.dk>
 S: Maintained
 F: trace/
 F: trace-events
@@ -3174,6 +3175,11 @@ F: docs/tools/qemu-trace-stap.rst
 F: docs/devel/tracing.rst
 T: git https://github.com/stefanha/qemu.git tracing
 
+Simpletrace
+M: Mads Ynddal <mads@ynddal.dk>
+S: Maintained
+F: scripts/simpletrace.py
+
 TPM
 M: Stefan Berger <stefanb@linux.ibm.com>
 S: Maintained
-- 
2.38.1

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

Posted by Stefan Hajnoczi 1 year, 2 months ago

On Wed, Aug 23, 2023 at 10:54:28AM +0200, Mads Ynddal wrote:
> From: Mads Ynddal <m.ynddal@samsung.com>
> 
> In my work to refactor simpletrace.py, I noticed that there's no
> maintainer of it, and has the status of "odd fixes". I'm using it from
> time to time, so I'd like to maintain the script.
> 
> I've added myself as reviewer under "Tracing" to be informed of changes
> that might affect simpletrace.py.

I treat simpletrace.py as part of the tracing subsystem but it is
missing from the MAINTAINERS file.

You're welcome to be the maintainer. I haven't touched it in years.

When you have reviewed future simpletrace.py patches you can either post
your Reviewed-by and I'll include them in my tracing pull requests, or
you could send pull requests to the qemu.git maintainer yourself
(requires publishing a GPG key and signing pull request tags).

Please let me know which option you prefer.

> Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6111b6b4d9..2ffb608dec 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3162,6 +3162,7 @@ F: stubs/
>  
>  Tracing
>  M: Stefan Hajnoczi <stefanha@redhat.com>
> +R: Mads Ynddal <mads@ynddal.dk>
>  S: Maintained
>  F: trace/
>  F: trace-events
> @@ -3174,6 +3175,11 @@ F: docs/tools/qemu-trace-stap.rst
>  F: docs/devel/tracing.rst
>  T: git https://github.com/stefanha/qemu.git tracing
>  
> +Simpletrace
> +M: Mads Ynddal <mads@ynddal.dk>
> +S: Maintained
> +F: scripts/simpletrace.py
> +
>  TPM
>  M: Stefan Berger <stefanb@linux.ibm.com>
>  S: Maintained
> -- 
> 2.38.1
>

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

Posted by Mads Ynddal 1 year, 2 months ago

> You're welcome to be the maintainer. I haven't touched it in years.
> 
> When you have reviewed future simpletrace.py patches you can either post
> your Reviewed-by and I'll include them in my tracing pull requests, or
> you could send pull requests to the qemu.git maintainer yourself
> (requires publishing a GPG key and signing pull request tags).
> 
> Please let me know which option you prefer.

For future patches, I would like to send pull requests myself with a GPG key to 
get the practice. I can have Klaus Jensen <its@irrelevant.dk> sign my key to
get started.

—
Mads Ynddal

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

Posted by Stefan Hajnoczi 1 year, 2 months ago

On Tue, Sep 26, 2023, 06:27 Mads Ynddal <mads@ynddal.dk> wrote:

>
> > You're welcome to be the maintainer. I haven't touched it in years.
> >
> > When you have reviewed future simpletrace.py patches you can either post
> > your Reviewed-by and I'll include them in my tracing pull requests, or
> > you could send pull requests to the qemu.git maintainer yourself
> > (requires publishing a GPG key and signing pull request tags).
> >
> > Please let me know which option you prefer.
>
> For future patches, I would like to send pull requests myself with a GPG
> key to
> get the practice. I can have Klaus Jensen <its@irrelevant.dk> sign my key
> to
> get started.
>

Sounds good.

Stefan



> —
> Mads Ynddal
>
>
>

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

On 23/8/23 10:54, Mads Ynddal wrote:
> From: Mads Ynddal <m.ynddal@samsung.com>
> 
> In my work to refactor simpletrace.py, I noticed that there's no
> maintainer of it, and has the status of "odd fixes". I'm using it from
> time to time, so I'd like to maintain the script.
> 
> I've added myself as reviewer under "Tracing" to be informed of changes
> that might affect simpletrace.py.
> 
> Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
> ---
>   MAINTAINERS | 6 ++++++
>   1 file changed, 6 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>