Implement the mmap system call for FreeBSD.

[PATCH 01/22] Implement struct target_ipc_perm

Posted by Karim Taha 2 years, 5 months ago

From: Stacey Son <sson@FreeBSD.org>

Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
---
 bsd-user/syscall_defs.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h
index e4825f2662..39a9bc8ed7 100644
--- a/bsd-user/syscall_defs.h
+++ b/bsd-user/syscall_defs.h
@@ -55,6 +55,23 @@ struct target_iovec {
     abi_long iov_len;   /* Number of bytes */
 };
 
+/*
+ * sys/ipc.h
+ */
+struct target_ipc_perm {
+    uint32_t    cuid;       /* creator user id */
+    uint32_t    cgid;       /* creator group id */
+    uint32_t    uid;        /* user id */
+    uint32_t    gid;        /* group id */
+    uint16_t    mode;       /* r/w permission */
+    uint16_t    seq;        /* sequence # */
+    abi_long    key;        /* user specified msg/sem/shm key */
+};
+
+#define TARGET_IPC_RMID 0   /* remove identifier */
+#define TARGET_IPC_SET  1   /* set options */
+#define TARGET_IPC_STAT 2   /* get options */
+
 /*
  *  sys/mman.h
  */
-- 
2.40.0

Re: [PATCH 01/22] Implement struct target_ipc_perm

Posted by Warner Losh 2 years, 5 months ago

One general thing about all the patches in this series. The first line in
the
commit message should start with 'bsd-user: ' which I'll only say once.
You can fix it in v2 easily enough.

On Sat, Aug 19, 2023 at 3:48 AM Karim Taha <kariem.taha2.7@gmail.com> wrote:

> From: Stacey Son <sson@FreeBSD.org>
>
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
> ---
>  bsd-user/syscall_defs.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>


> diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h
> index e4825f2662..39a9bc8ed7 100644
> --- a/bsd-user/syscall_defs.h
> +++ b/bsd-user/syscall_defs.h
> @@ -55,6 +55,23 @@ struct target_iovec {
>      abi_long iov_len;   /* Number of bytes */
>  };
>
> +/*
> + * sys/ipc.h
> + */
> +struct target_ipc_perm {
> +    uint32_t    cuid;       /* creator user id */
> +    uint32_t    cgid;       /* creator group id */
> +    uint32_t    uid;        /* user id */
> +    uint32_t    gid;        /* group id */
> +    uint16_t    mode;       /* r/w permission */
> +    uint16_t    seq;        /* sequence # */
> +    abi_long    key;        /* user specified msg/sem/shm key */
> +};
> +
> +#define TARGET_IPC_RMID 0   /* remove identifier */
> +#define TARGET_IPC_SET  1   /* set options */
> +#define TARGET_IPC_STAT 2   /* get options */
> +
>  /*
>   *  sys/mman.h
>   */
> --
> 2.40.0
>
>

Re: [PATCH 01/22] Implement struct target_ipc_perm

Posted by Richard Henderson 2 years, 5 months ago

On 8/19/23 02:47, Karim Taha wrote:
> From: Stacey Son<sson@FreeBSD.org>
> 
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Karim Taha<kariem.taha2.7@gmail.com>
> ---
>   bsd-user/syscall_defs.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~