[PATCH v2 0/4] migration/ram: Merge zero page handling

Fabiano Rosas posted 4 patches 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230816182817.17590-1-farosas@suse.de
Maintainers: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>
migration/ram.c | 75 ++++++++++++++++++++-----------------------------
1 file changed, 30 insertions(+), 45 deletions(-)
[PATCH v2 0/4] migration/ram: Merge zero page handling
Posted by Fabiano Rosas 9 months ago
For v2 I fixed patch 3 which had a hunk belonging to patch 5.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/969706915

v1:
https://lore.kernel.org/r/20230815143828.15436-1-farosas@suse.de

Hi,

This is another small series that I extracted from my fixed-ram series
and that could be already considered for merging.

This is just code movement, no functional change. The objective is to
consolidate the zero page handling in the same routine that saves the
page header and does accounting. Then in the future I'll be able to
just return early because fixed-ram ignores zero pages.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/968300062

Fabiano Rosas (4):
  migration/ram: Remove RAMState from xbzrle_cache_zero_page
  migration/ram: Stop passing QEMUFile around in save_zero_page
  migration/ram: Move xbzrle zero page handling into save_zero_page
  migration/ram: Merge save_zero_page functions

 migration/ram.c | 75 ++++++++++++++++++++-----------------------------
 1 file changed, 30 insertions(+), 45 deletions(-)

-- 
2.35.3
Re: [PATCH v2 0/4] migration/ram: Merge zero page handling
Posted by Claudio Fontana 9 months ago
Hello,

this series is all reviewed,

and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore
when migrating to disk, can it be merged?

Thanks,

Claudio

On 8/16/23 20:28, Fabiano Rosas wrote:
> For v2 I fixed patch 3 which had a hunk belonging to patch 5.
> 
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/969706915
> 
> v1:
> https://lore.kernel.org/r/20230815143828.15436-1-farosas@suse.de
> 
> Hi,
> 
> This is another small series that I extracted from my fixed-ram series
> and that could be already considered for merging.
> 
> This is just code movement, no functional change. The objective is to
> consolidate the zero page handling in the same routine that saves the
> page header and does accounting. Then in the future I'll be able to
> just return early because fixed-ram ignores zero pages.
> 
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/968300062
> 
> Fabiano Rosas (4):
>   migration/ram: Remove RAMState from xbzrle_cache_zero_page
>   migration/ram: Stop passing QEMUFile around in save_zero_page
>   migration/ram: Move xbzrle zero page handling into save_zero_page
>   migration/ram: Merge save_zero_page functions
> 
>  migration/ram.c | 75 ++++++++++++++++++++-----------------------------
>  1 file changed, 30 insertions(+), 45 deletions(-)
>