[PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation

Markus Armbruster posted 6 patches 2 years, 6 months ago
Maintainers: Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Jason Wang <jasowang@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
[PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation
Posted by Markus Armbruster 2 years, 6 months ago
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/char.json | 2 +-
 qapi/misc.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/char.json b/qapi/char.json
index e413ac2b70..52aaff25eb 100644
--- a/qapi/char.json
+++ b/qapi/char.json
@@ -18,7 +18,7 @@
 # @filename: the filename of the character device
 #
 # @frontend-open: shows whether the frontend device attached to this
-#     backend (eg. with the chardev=... option) is in open or closed
+#     backend (e.g. with the chardev=... option) is in open or closed
 #     state (since 2.1)
 #
 # Notes: @filename is encoded using the QEMU command line character
diff --git a/qapi/misc.json b/qapi/misc.json
index ff070ec828..cda2effa81 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -18,7 +18,7 @@
 # fail and the FD will be closed.
 #
 # @protocol: protocol name.  Valid names are "vnc", "spice",
-#     "@dbus-display" or the name of a character device (eg. from
+#     "@dbus-display" or the name of a character device (e.g. from
 #     -chardev id=XXXX)
 #
 # @fdname: file descriptor name previously passed via 'getfd' command
-- 
2.41.0
Re: [PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
Hi Markus,

On 20/7/23 09:16, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   qapi/char.json | 2 +-
>   qapi/misc.json | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qapi/char.json b/qapi/char.json
> index e413ac2b70..52aaff25eb 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -18,7 +18,7 @@
>   # @filename: the filename of the character device
>   #
>   # @frontend-open: shows whether the frontend device attached to this
> -#     backend (eg. with the chardev=... option) is in open or closed
> +#     backend (e.g. with the chardev=... option) is in open or closed
>   #     state (since 2.1)
>   #
>   # Notes: @filename is encoded using the QEMU command line character
> diff --git a/qapi/misc.json b/qapi/misc.json
> index ff070ec828..cda2effa81 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -18,7 +18,7 @@
>   # fail and the FD will be closed.
>   #
>   # @protocol: protocol name.  Valid names are "vnc", "spice",
> -#     "@dbus-display" or the name of a character device (eg. from
> +#     "@dbus-display" or the name of a character device (e.g. from
>   #     -chardev id=XXXX)
>   #
>   # @fdname: file descriptor name previously passed via 'getfd' command

$ git grep -wF 'eg.' | wc -l
       45

Why not fix all the tree?
Re: [PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation
Posted by Markus Armbruster 2 years, 6 months ago
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Hi Markus,
>
> On 20/7/23 09:16, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>   qapi/char.json | 2 +-
>>   qapi/misc.json | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/qapi/char.json b/qapi/char.json
>> index e413ac2b70..52aaff25eb 100644
>> --- a/qapi/char.json
>> +++ b/qapi/char.json
>> @@ -18,7 +18,7 @@
>>   # @filename: the filename of the character device
>>   #
>>   # @frontend-open: shows whether the frontend device attached to this
>> -#     backend (eg. with the chardev=... option) is in open or closed
>> +#     backend (e.g. with the chardev=... option) is in open or closed
>>   #     state (since 2.1)
>>   #
>>   # Notes: @filename is encoded using the QEMU command line character
>> diff --git a/qapi/misc.json b/qapi/misc.json
>> index ff070ec828..cda2effa81 100644
>> --- a/qapi/misc.json
>> +++ b/qapi/misc.json
>> @@ -18,7 +18,7 @@
>>   # fail and the FD will be closed.
>>   #
>>   # @protocol: protocol name.  Valid names are "vnc", "spice",
>> -#     "@dbus-display" or the name of a character device (eg. from
>> +#     "@dbus-display" or the name of a character device (e.g. from
>>   #     -chardev id=XXXX)
>>   #
>>   # @fdname: file descriptor name previously passed via 'getfd' command
>
> $ git grep -wF 'eg.' | wc -l
>       45
>
> Why not fix all the tree?

Because I have qapi/ myopia today?