tests/qtest: Fix typo in multifd cancel test

[PATCH] tests/qtest: Fix typo in multifd cancel test

Fabiano Rosas posted 1 patch 2 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230711212131.2370-1-farosas@suse.de

Maintainers: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/qtest: Fix typo in multifd cancel test

Posted by Fabiano Rosas 2 years, 5 months ago

This wasn't noticed because the test is currently disabled.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Fixes: 02f56e3de ("tests/qtest: massively speed up migration-test")
---
 tests/qtest/migration-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index efa8c729db..e256da1216 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -2481,7 +2481,7 @@ static void test_multifd_tcp_cancel(void)
 
     migrate_qmp(from, uri, "{}");
 
-    migrate_wait_for_dirty_mem(from, to);
+    migrate_wait_for_dirty_mem(from, to2);
 
     migrate_ensure_converge(from);
 
-- 
2.35.3

Re: [PATCH] tests/qtest: Fix typo in multifd cancel test

Posted by Daniel P. Berrangé 2 years, 5 months ago

On Tue, Jul 11, 2023 at 06:21:31PM -0300, Fabiano Rosas wrote:
> This wasn't noticed because the test is currently disabled.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Fixes: 02f56e3de ("tests/qtest: massively speed up migration-test")
> ---
>  tests/qtest/migration-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index efa8c729db..e256da1216 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -2481,7 +2481,7 @@ static void test_multifd_tcp_cancel(void)
>  
>      migrate_qmp(from, uri, "{}");
>  
> -    migrate_wait_for_dirty_mem(from, to);
> +    migrate_wait_for_dirty_mem(from, to2);
>  
>      migrate_ensure_converge(from);
>  
> -- 
> 2.35.3
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|