[v2] hw/virtio: Build vhost-vdpa.o once for all targets

[PATCH v2 5/6] hw/virtio: Build vhost-vdpa.o once

Posted by Philippe Mathieu-Daudé 2 years, 7 months ago

The previous commit removed the dependencies on the
target-specific TARGET_PAGE_FOO macros. We can now
move vhost-vdpa.c to the 'softmmu_virtio_ss' source
set to build it once for all our targets.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/virtio/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build
index f32b22f61b..900864c1be 100644
--- a/hw/virtio/meson.build
+++ b/hw/virtio/meson.build
@@ -18,7 +18,8 @@ if have_vhost
     specific_virtio_ss.add(files('vhost-user.c'))
   endif
   if have_vhost_vdpa
-    specific_virtio_ss.add(files('vhost-vdpa.c', 'vhost-shadow-virtqueue.c'))
+    softmmu_virtio_ss.add(files('vhost-vdpa.c'))
+    specific_virtio_ss.add(files('vhost-shadow-virtqueue.c'))
   endif
 else
   softmmu_virtio_ss.add(files('vhost-stub.c'))
-- 
2.38.1

Re: [PATCH v2 5/6] hw/virtio: Build vhost-vdpa.o once

Posted by Richard Henderson 2 years, 7 months ago

On 7/7/23 16:17, Philippe Mathieu-Daudé wrote:
> The previous commit removed the dependencies on the
> target-specific TARGET_PAGE_FOO macros. We can now
> move vhost-vdpa.c to the 'softmmu_virtio_ss' source
> set to build it once for all our targets.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/virtio/meson.build | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~