chardev/char-fe: Document FEWatchFunc and use G_SOURCE_CONTINUE/REMOVE

[PATCH 0/4] chardev/char-fe: Document FEWatchFunc and use G_SOURCE_CONTINUE/REMOVE

Philippe Mathieu-Daudé posted 4 patches 9 months, 3 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230705133139.54419-1-philmd@linaro.org

Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Alistair Francis <alistair@alistair23.me>, Peter Maydell <peter.maydell@linaro.org>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Joel Stanley <joel@jms.id.au>, "Michael S. Tsirkin" <mst@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Amit Shah <amit@kernel.org>, Gerd Hoffmann <kraxel@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Markus Armbruster <armbru@redhat.com>, Jason Wang <jasowang@redhat.com>

include/chardev/char-fe.h | 18 ++++++++++++++++--
include/io/channel.h      |  2 +-
hw/char/cadence_uart.c    |  8 ++++----
hw/char/cmsdk-apb-uart.c  |  6 +++---
hw/char/ibex_uart.c       |  8 ++++----
hw/char/nrf51_uart.c      |  4 ++--
hw/char/serial.c          |  2 +-
hw/char/virtio-console.c  |  2 +-
hw/usb/redirect.c         |  2 +-
monitor/monitor.c         |  2 +-
net/vhost-user.c          |  2 +-
11 files changed, 35 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH 0/4] chardev/char-fe: Document FEWatchFunc and use G_SOURCE_CONTINUE/REMOVE

Posted by Philippe Mathieu-Daudé 9 months, 3 weeks ago

Improve qio and chardev frontend documentation,
have FEWatchFunc handlers return G_SOURCE_CONTINUE/REMOVE.

Philippe Mathieu-Daudé (4):
  io/channel: Explicit QIOChannel doc is based on GLib's IOChannel
  chardev/char-fe: Clarify qemu_chr_fe_add_watch 'condition' arg is a
    mask
  chardev/char-fe: Document FEWatchFunc typedef
  hw/char: Have FEWatchFunc handlers return G_SOURCE_CONTINUE/REMOVE

 include/chardev/char-fe.h | 18 ++++++++++++++++--
 include/io/channel.h      |  2 +-
 hw/char/cadence_uart.c    |  8 ++++----
 hw/char/cmsdk-apb-uart.c  |  6 +++---
 hw/char/ibex_uart.c       |  8 ++++----
 hw/char/nrf51_uart.c      |  4 ++--
 hw/char/serial.c          |  2 +-
 hw/char/virtio-console.c  |  2 +-
 hw/usb/redirect.c         |  2 +-
 monitor/monitor.c         |  2 +-
 net/vhost-user.c          |  2 +-
 11 files changed, 35 insertions(+), 21 deletions(-)

-- 
2.38.1

Re: [PATCH 0/4] chardev/char-fe: Document FEWatchFunc and use G_SOURCE_CONTINUE/REMOVE

Posted by Philippe Mathieu-Daudé 9 months, 3 weeks ago

Hi Paolo & Marc-André,

On 5/7/23 15:31, Philippe Mathieu-Daudé wrote:
> Improve qio and chardev frontend documentation,
> have FEWatchFunc handlers return G_SOURCE_CONTINUE/REMOVE.
> 
> Philippe Mathieu-Daudé (4):
>    io/channel: Explicit QIOChannel doc is based on GLib's IOChannel
>    chardev/char-fe: Clarify qemu_chr_fe_add_watch 'condition' arg is a
>      mask
>    chardev/char-fe: Document FEWatchFunc typedef
>    hw/char: Have FEWatchFunc handlers return G_SOURCE_CONTINUE/REMOVE

Could you Ack patches 2-4?