[v1] pci: Compare function number and ARI next function number

[PATCH 0/4] pci: Compare function number and ARI next function number

Akihiko Odaki posted 4 patches 2 years, 5 months ago

Diff against v6 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230701070133.24877-1-akihiko.odaki@daynix.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Sriram Yagnaraman <sriram.yagnaraman@est.tech>, Jason Wang <jasowang@redhat.com>, Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>

There is a newer version of this series

docs/pcie_sriov.txt |  5 +++--
hw/net/igb_core.h   |  3 +++
hw/net/igb.c        |  4 +---
hw/net/igbvf.c      |  5 ++++-
hw/nvme/ctrl.c      |  7 ++++++-
hw/pci/pci.c        | 15 +++++++++++++++
6 files changed, 32 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH 0/4] pci: Compare function number and ARI next function number

Posted by Akihiko Odaki 2 years, 5 months ago

The function number must be lower than the next function number
advertised with ARI. Add a check to enforce this.

I suggested this change at:
https://lore.kernel.org/qemu-devel/bf351f8b-1c8a-8a7a-7f44-17c9ba18f179@daynix.com/

Implementing this change, I found the devices implementing ARI do not set the
correct next function numbers, which is also fixed in this series.

Akihiko Odaki (4):
  docs: Fix next function numbers in SR/IOV documentation
  hw/nvme: Fix ARI next function numbers
  igb: Fix ARI next function numbers
  pci: Compare function number and ARI next function number

 docs/pcie_sriov.txt |  5 +++--
 hw/net/igb_core.h   |  3 +++
 hw/net/igb.c        |  4 +---
 hw/net/igbvf.c      |  5 ++++-
 hw/nvme/ctrl.c      |  7 ++++++-
 hw/pci/pci.c        | 15 +++++++++++++++
 6 files changed, 32 insertions(+), 7 deletions(-)

-- 
2.41.0

Re: [PATCH 0/4] pci: Compare function number and ARI next function number

Posted by Michael S. Tsirkin 2 years, 5 months ago

On Sat, Jul 01, 2023 at 04:01:18PM +0900, Akihiko Odaki wrote:
> The function number must be lower than the next function number
> advertised with ARI. Add a check to enforce this.
> 
> I suggested this change at:
> https://lore.kernel.org/qemu-devel/bf351f8b-1c8a-8a7a-7f44-17c9ba18f179@daynix.com/
> 
> Implementing this change, I found the devices implementing ARI do not set the
> correct next function numbers, which is also fixed in this series.

This isn't going to be merged with more in the way of motivation.

Analysis of at least linux guest behavious, documentation about testing,
addressing migration concerns are all not there either.



> Akihiko Odaki (4):
>   docs: Fix next function numbers in SR/IOV documentation
>   hw/nvme: Fix ARI next function numbers
>   igb: Fix ARI next function numbers
>   pci: Compare function number and ARI next function number
> 
>  docs/pcie_sriov.txt |  5 +++--
>  hw/net/igb_core.h   |  3 +++
>  hw/net/igb.c        |  4 +---
>  hw/net/igbvf.c      |  5 ++++-
>  hw/nvme/ctrl.c      |  7 ++++++-
>  hw/pci/pci.c        | 15 +++++++++++++++
>  6 files changed, 32 insertions(+), 7 deletions(-)
> 
> -- 
> 2.41.0