[PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header

Philippe Mathieu-Daudé posted 4 patches 2 years, 7 months ago
Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
[PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago
Commit 1e05888ab5 ("sysemu/kvm: Remove unused headers") was
a bit overzealous while cleaning "sysemu/kvm.h" headers:
kvm_arch_post_run() returns a MemTxAttrs type, so depends on
"exec/memattrs.h" for its definition.

Fixes: 1e05888ab5 ("sysemu/kvm: Remove unused headers")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/sysemu/kvm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index 88f5ccfbce..528966b5a8 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -14,6 +14,7 @@
 #ifndef QEMU_KVM_H
 #define QEMU_KVM_H
 
+#include "exec/memattrs.h"
 #include "qemu/accel.h"
 #include "qom/object.h"
 
-- 
2.38.1


Re: [PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header
Posted by Richard Henderson 2 years, 7 months ago
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote:
> Commit 1e05888ab5 ("sysemu/kvm: Remove unused headers") was
> a bit overzealous while cleaning "sysemu/kvm.h" headers:
> kvm_arch_post_run() returns a MemTxAttrs type, so depends on
> "exec/memattrs.h" for its definition.
> 
> Fixes: 1e05888ab5 ("sysemu/kvm: Remove unused headers")
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   include/sysemu/kvm.h | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~