target/hppa/meson: Only build int_helper.o with system emulation

[PATCH] target/hppa/meson: Only build int_helper.o with system emulation

Philippe Mathieu-Daudé posted 1 patch 10 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230602223016.58647-1-philmd@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>

target/hppa/int_helper.c | 3 ---
target/hppa/meson.build  | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)

Expand all Fold all

[PATCH] target/hppa/meson: Only build int_helper.o with system emulation

Posted by Philippe Mathieu-Daudé 10 months, 4 weeks ago

int_helper.c only contains system emulation code:
remove the #ifdef'ry and move the file to the meson
softmmu source set.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/int_helper.c | 3 ---
 target/hppa/meson.build  | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c
index f599dccfff..d2480b163b 100644
--- a/target/hppa/int_helper.c
+++ b/target/hppa/int_helper.c
@@ -25,7 +25,6 @@
 #include "hw/core/cpu.h"
 #include "hw/hppa/hppa_hardware.h"
 
-#ifndef CONFIG_USER_ONLY
 static void eval_interrupt(HPPACPU *cpu)
 {
     CPUState *cs = CPU(cpu);
@@ -273,5 +272,3 @@ bool hppa_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
     }
     return false;
 }
-
-#endif /* !CONFIG_USER_ONLY */
diff --git a/target/hppa/meson.build b/target/hppa/meson.build
index 81b4b4e617..83b1e0ee7d 100644
--- a/target/hppa/meson.build
+++ b/target/hppa/meson.build
@@ -7,13 +7,13 @@ hppa_ss.add(files(
   'fpu_helper.c',
   'gdbstub.c',
   'helper.c',
-  'int_helper.c',
   'op_helper.c',
   'translate.c',
 ))
 
 hppa_softmmu_ss = ss.source_set()
 hppa_softmmu_ss.add(files(
+  'int_helper.c',
   'machine.c',
   'mem_helper.c',
   'sys_helper.c',
-- 
2.38.1

Re: [PATCH] target/hppa/meson: Only build int_helper.o with system emulation

Posted by Richard Henderson 10 months, 4 weeks ago

On 6/2/23 15:30, Philippe Mathieu-Daudé wrote:
> int_helper.c only contains system emulation code:
> remove the #ifdef'ry and move the file to the meson
> softmmu source set.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   target/hppa/int_helper.c | 3 ---
>   target/hppa/meson.build  | 2 +-
>   2 files changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~