[PATCH 1/6] qtest: bump min meson timeout to 60 seconds

Daniel P. Berrangé posted 6 patches 2 years, 8 months ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Laurent Vivier <lvivier@redhat.com>
There is a newer version of this series
[PATCH 1/6] qtest: bump min meson timeout to 60 seconds
Posted by Daniel P. Berrangé 2 years, 8 months ago
Even some of the relatively fast qtests can sometimes hit the 30 second
timeout in GitLab CI under high parallelism/load conditions. Bump the
min to 60 seconds to give a higher margin for reliability.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qtest/meson.build | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 087f2dc9d7..18d046b53c 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -1,12 +1,7 @@
 slow_qtests = {
-  'ahci-test' : 60,
   'bios-tables-test' : 120,
-  'boot-serial-test' : 60,
   'migration-test' : 150,
   'npcm7xx_pwm-test': 150,
-  'prom-env-test' : 60,
-  'pxe-test' : 60,
-  'qos-test' : 60,
   'qom-test' : 300,
   'test-hmp' : 120,
 }
@@ -373,8 +368,8 @@ foreach dir : target_dirs
          env: qtest_env,
          args: ['--tap', '-k'],
          protocol: 'tap',
-         timeout: slow_qtests.get(test, 30),
-         priority: slow_qtests.get(test, 30),
+         timeout: slow_qtests.get(test, 60),
+         priority: slow_qtests.get(test, 60),
          suite: ['qtest', 'qtest-' + target_base])
   endforeach
 endforeach
-- 
2.40.1


Re: [PATCH 1/6] qtest: bump min meson timeout to 60 seconds
Posted by Thomas Huth 2 years, 8 months ago
On 01/06/2023 18.31, Daniel P. Berrangé wrote:
> Even some of the relatively fast qtests can sometimes hit the 30 second
> timeout in GitLab CI under high parallelism/load conditions. Bump the
> min to 60 seconds to give a higher margin for reliability.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qtest/meson.build | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 087f2dc9d7..18d046b53c 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -1,12 +1,7 @@
>   slow_qtests = {
> -  'ahci-test' : 60,
>     'bios-tables-test' : 120,
> -  'boot-serial-test' : 60,
>     'migration-test' : 150,
>     'npcm7xx_pwm-test': 150,
> -  'prom-env-test' : 60,
> -  'pxe-test' : 60,
> -  'qos-test' : 60,
>     'qom-test' : 300,
>     'test-hmp' : 120,
>   }
> @@ -373,8 +368,8 @@ foreach dir : target_dirs
>            env: qtest_env,
>            args: ['--tap', '-k'],
>            protocol: 'tap',
> -         timeout: slow_qtests.get(test, 30),
> -         priority: slow_qtests.get(test, 30),
> +         timeout: slow_qtests.get(test, 60),
> +         priority: slow_qtests.get(test, 60),
>            suite: ['qtest', 'qtest-' + target_base])
>     endforeach
>   endforeach

Reviewed-by: Thomas Huth <thuth@redhat.com>