On 01.06.23 14:14, David Hildenbrand wrote:
> Working on adding multi-memslot support for virtio-mem (teaching memory
> device code about memory devices that can consume multiple memslots), I
> have some preparatory cleanups in my queue that make sense independent of
> the actual memory-device/virtio-mem extensions.
>
> v2 -> v3:
> - "memory-device: Introduce machine_memory_devices_init()"
> -- Declare the function in hw/boards.h
> - "hw/loongarch/virt: Use machine_memory_devices_init()"
> -- Use VIRT_HIGHMEM_BASE
> -- No need to include memory-device.h
> - "hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZ"
> -- Add more details why it's ok to the patch description
> - Adjust to memory_devices_init() -> machine_memory_devices_init()
> - Add RBs
>
> v1 -> v2:
> - Allocate ms->device_memory only if the size > 0.
> - Split it up and include more cleanups
>
> David Hildenbrand (10):
> memory-device: Unify enabled vs. supported error messages
> memory-device: Introduce machine_memory_devices_init()
> hw/arm/virt: Use machine_memory_devices_init()
> hw/ppc/spapr: Use machine_memory_devices_init()
> hw/loongarch/virt: Use machine_memory_devices_init()
> hw/i386/pc: Use machine_memory_devices_init()
> hw/i386/acpi-build: Rely on machine->device_memory when building SRAT
> hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE
> memory-device: Refactor memory_device_pre_plug()
> memory-device: Track used region size in DeviceMemoryState
>
> hw/arm/virt.c | 9 +-----
> hw/i386/acpi-build.c | 9 ++----
> hw/i386/pc.c | 36 +++-------------------
> hw/loongarch/virt.c | 12 ++------
> hw/mem/memory-device.c | 69 +++++++++++++++++++-----------------------
> hw/ppc/spapr.c | 37 +++++++++++-----------
> hw/ppc/spapr_hcall.c | 2 +-
> include/hw/boards.h | 4 +++
> include/hw/i386/pc.h | 1 -
> 9 files changed, 67 insertions(+), 112 deletions(-)
>
Any further comments? If not, I'm planning on taking this through my
memory-device tree.
--
Cheers,
David / dhildenb