Added 32 bits property for ASPEED GPIO with updated qtests. This change gives ASPEED GPIO similar behavior as Nuvoton.

[PATCH 0/2] Added 32 bits property for ASPEED GPIO with updated qtests. This change gives ASPEED GPIO similar behavior as Nuvoton.

Jingbo Wu posted 2 patches 10 months, 3 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230531165537.3721999-1-flwu@google.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>, Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

hw/gpio/aspeed_gpio.c          |  56 ++++++++++++++++++
include/qapi/qmp/qdict.h       |   1 +
qobject/qdict.c                |  13 ++++
tests/qtest/aspeed_gpio-test.c | 105 ++++++++++++++++++++++++++++++---
4 files changed, 166 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH 0/2] Added 32 bits property for ASPEED GPIO with updated qtests. This change gives ASPEED GPIO similar behavior as Nuvoton.

Posted by Jingbo Wu 10 months, 3 weeks ago

From: Felix Wu <flwu@google.com>


Felix Wu (2):
  hw/gpio: Add property for ASPEED GPIO in 32 bits basis
  tests/qtest: Add qtest for for ASPEED GPIO gpio-set property

 hw/gpio/aspeed_gpio.c          |  56 ++++++++++++++++++
 include/qapi/qmp/qdict.h       |   1 +
 qobject/qdict.c                |  13 ++++
 tests/qtest/aspeed_gpio-test.c | 105 ++++++++++++++++++++++++++++++---
 4 files changed, 166 insertions(+), 9 deletions(-)

-- 
2.41.0.rc0.172.g3f132b7071-goog

Re: [PATCH 0/2] Added 32 bits property for ASPEED GPIO with updated qtests. This change gives ASPEED GPIO similar behavior as Nuvoton.

Posted by Cédric Le Goater 10 months, 3 weeks ago

On 5/31/23 18:55, Jingbo Wu wrote:
> From: Felix Wu <flwu@google.com>

Hello Felix,

Thanks for the extension. It could be useful in some situations but
it seems also dangerous to set all lines controlled by a register
at once. The same comment applies to Nuvoton [1].

C.

[1] https://lore.kernel.org/qemu-devel/CAFEAcA-2_gwOUgapmgSSFGVNiOk9Grse_E3TVo=pQTf-OgW2vg@mail.gmail.com/


> 
> Felix Wu (2):
>    hw/gpio: Add property for ASPEED GPIO in 32 bits basis
>    tests/qtest: Add qtest for for ASPEED GPIO gpio-set property
> 
>   hw/gpio/aspeed_gpio.c          |  56 ++++++++++++++++++
>   include/qapi/qmp/qdict.h       |   1 +
>   qobject/qdict.c                |  13 ++++
>   tests/qtest/aspeed_gpio-test.c | 105 ++++++++++++++++++++++++++++++---
>   4 files changed, 166 insertions(+), 9 deletions(-)
>