[RFC 0/2] migration: Update error description outside migration.c

Tejus GK posted 2 patches 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230526115003.212004-1-tejus.gk@nutanix.com
Maintainers: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>
There is a newer version of this series
include/migration/vmstate.h |  4 +++-
migration/savevm.c          | 19 +++++++++++++++----
migration/vmstate.c         | 19 +++++++++++++------
3 files changed, 31 insertions(+), 11 deletions(-)
[RFC 0/2] migration: Update error description outside migration.c
Posted by Tejus GK 1 year ago
Hi everyone,

This patchset aims to cover code paths in the source code where a 
migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
failure exists outside of migration.c, and without a call for 
migrate_set_error at this place. 

This patchset has been split out from the patchset sent before which 
covered cases of such gaps in migration.c aswell.

Previous patchset: 
https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 

Regards, 
Tejus

Tejus GK (2):
  migration/vmstate: Introduce vmstate_save_state_with_err
  migration: Update error description outside migration.c

 include/migration/vmstate.h |  4 +++-
 migration/savevm.c          | 19 +++++++++++++++----
 migration/vmstate.c         | 19 +++++++++++++------
 3 files changed, 31 insertions(+), 11 deletions(-)

-- 
2.22.3
Re: [RFC 0/2] migration: Update error description outside migration.c
Posted by Peter Xu 1 year ago
On Fri, May 26, 2023 at 11:50:01AM +0000, Tejus GK wrote:
> Hi everyone,
> 
> This patchset aims to cover code paths in the source code where a 
> migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
> failure exists outside of migration.c, and without a call for 
> migrate_set_error at this place. 
> 
> This patchset has been split out from the patchset sent before which 
> covered cases of such gaps in migration.c aswell.
> 
> Previous patchset: 
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu
Re: [RFC 0/2] migration: Update error description outside migration.c
Posted by Tejus GK 1 year ago

On 26/05/23 5:20 pm, Tejus GK wrote:
> Hi everyone,
> 
> This patchset aims to cover code paths in the source code where a 
> migration is marked as failed via MIGRATION_STATUS_FAILED, however the 
> failure exists outside of migration.c, and without a call for 
> migrate_set_error at this place. 
> 
> This patchset has been split out from the patchset sent before which 
> covered cases of such gaps in migration.c aswell.
> 
> Previous patchset: 
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04463.html 
> 
> Regards, 
> Tejus
> 
> Tejus GK (2):
>   migration/vmstate: Introduce vmstate_save_state_with_err
>   migration: Update error description outside migration.c
> 
>  include/migration/vmstate.h |  4 +++-
>  migration/savevm.c          | 19 +++++++++++++++----
>  migration/vmstate.c         | 19 +++++++++++++------
>  3 files changed, 31 insertions(+), 11 deletions(-)
> 

Hi everyone, 

Apologies for the delayed ping. Can someone please review this patchset?

Regards,
Tejus