[PATCH v2 0/2] qemu-img: fix getting stuck in infinite loop on in-chain rebase

Andrey Drobyshev via posted 2 patches 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230525180213.902012-1-andrey.drobyshev@virtuozzo.com
Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
qemu-img.c                 | 13 ++++++++-
tests/qemu-iotests/024     | 57 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/024.out | 30 ++++++++++++++++++++
3 files changed, 99 insertions(+), 1 deletion(-)
[PATCH v2 0/2] qemu-img: fix getting stuck in infinite loop on in-chain rebase
Posted by Andrey Drobyshev via 1 year ago
v1 -> v2:

  * Avoid breaking the loop just yet, as the offsets beyond the old
    backing size need to be explicitly zeroed;
  * Amend the commit message accordingly;
  * Alter the added test case to take the last zeroed cluster into
    consideration.

v1: https://lists.nongnu.org/archive/html/qemu-block/2023-05/msg00674.html

Andrey Drobyshev (2):
  qemu-img: rebase: stop when reaching EOF of old backing file
  qemu-iotests: 024: add rebasing test case for overlay_size >
    backing_size

 qemu-img.c                 | 13 ++++++++-
 tests/qemu-iotests/024     | 57 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/024.out | 30 ++++++++++++++++++++
 3 files changed, 99 insertions(+), 1 deletion(-)

-- 
2.31.1
Re: [PATCH v2 0/2] qemu-img: fix getting stuck in infinite loop on in-chain rebase
Posted by Andrey Drobyshev 1 year ago
On 5/25/23 21:02, Andrey Drobyshev wrote:
> v1 -> v2:
> 
>   * Avoid breaking the loop just yet, as the offsets beyond the old
>     backing size need to be explicitly zeroed;
>   * Amend the commit message accordingly;
>   * Alter the added test case to take the last zeroed cluster into
>     consideration.
> 
> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-05/msg00674.html
> 
> Andrey Drobyshev (2):
>   qemu-img: rebase: stop when reaching EOF of old backing file
>   qemu-iotests: 024: add rebasing test case for overlay_size >
>     backing_size
> 
>  qemu-img.c                 | 13 ++++++++-
>  tests/qemu-iotests/024     | 57 ++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/024.out | 30 ++++++++++++++++++++
>  3 files changed, 99 insertions(+), 1 deletion(-)
> 

Since there're no comments so far, I've included this same bugfix into
the bigger series regarding "qemu-img rebase".  Please refer to
https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00068.html.