[PATCH v9 0/7] igb: packet-split descriptors support

Tomasz Dzieciol posted 7 patches 11 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
hw/net/e1000e_core.c     |  78 +++--
hw/net/igb_core.c        | 740 ++++++++++++++++++++++++++++-----------
hw/net/igb_regs.h        |  20 +-
hw/net/trace-events      |   6 +-
tests/qtest/libqos/igb.c |   5 +
5 files changed, 602 insertions(+), 247 deletions(-)
[PATCH v9 0/7] igb: packet-split descriptors support
Posted by Tomasz Dzieciol 11 months ago
Based-on: <20230523024339.50875-1-akihiko.odaki@daynix.com>
("[PATCH v5 00/48] igb: Fix for DPDK")

Purposes of this series of patches:
* introduce packet-split RX descriptors support. This feature is used by Linux
  VF driver for MTU values from 2048.
* refactor RX descriptor handling for introduction of packet-split RX
  descriptors support
* fix descriptors flags handling

In addition to comments from previous review endianess issues in
igb_write_adv_ps_rx_descr were fixed.

Tomasz Dzieciol (7):
  igb: remove TCP ACK detection
  igb: rename E1000E_RingInfo_st
  igb: RX descriptors guest writting refactoring
  igb: RX payload guest writting refactoring
  igb: add IPv6 extended headers traffic detection
  igb: packet-split descriptors support
  e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers

 hw/net/e1000e_core.c     |  78 +++--
 hw/net/igb_core.c        | 740 ++++++++++++++++++++++++++++-----------
 hw/net/igb_regs.h        |  20 +-
 hw/net/trace-events      |   6 +-
 tests/qtest/libqos/igb.c |   5 +
 5 files changed, 602 insertions(+), 247 deletions(-)

-- 
2.25.1
Re: [PATCH v9 0/7] igb: packet-split descriptors support
Posted by Akihiko Odaki 10 months, 4 weeks ago
On 2023/05/26 0:37, Tomasz Dzieciol wrote:
> Based-on: <20230523024339.50875-1-akihiko.odaki@daynix.com>
> ("[PATCH v5 00/48] igb: Fix for DPDK")
> 
> Purposes of this series of patches:
> * introduce packet-split RX descriptors support. This feature is used by Linux
>    VF driver for MTU values from 2048.
> * refactor RX descriptor handling for introduction of packet-split RX
>    descriptors support
> * fix descriptors flags handling
> 
> In addition to comments from previous review endianess issues in
> igb_write_adv_ps_rx_descr were fixed.
> 
> Tomasz Dzieciol (7):
>    igb: remove TCP ACK detection
>    igb: rename E1000E_RingInfo_st
>    igb: RX descriptors guest writting refactoring
>    igb: RX payload guest writting refactoring
>    igb: add IPv6 extended headers traffic detection
>    igb: packet-split descriptors support
>    e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers
> 
>   hw/net/e1000e_core.c     |  78 +++--
>   hw/net/igb_core.c        | 740 ++++++++++++++++++++++++++++-----------
>   hw/net/igb_regs.h        |  20 +-
>   hw/net/trace-events      |   6 +-
>   tests/qtest/libqos/igb.c |   5 +
>   5 files changed, 602 insertions(+), 247 deletions(-)
> 

Please rebase to the current master and remove Based-on: tag. This 
series should cleanly apply.

I left some minor comments that does not involve semantic changes so 
check them out. I think I can give Reviewed-by: and Tested-by: for the 
next version. Thanks for keeping working on this.

Regards,
Akihiko Odaki