[PATCH 3/9] util: Add i386 CPUINFO_ATOMIC_VMOVDQU

Richard Henderson posted 9 patches 2 years, 8 months ago
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
[PATCH 3/9] util: Add i386 CPUINFO_ATOMIC_VMOVDQU
Posted by Richard Henderson 2 years, 8 months ago
Add a bit to indicate when VMOVDQU is also atomic if aligned.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/host/i386/cpuinfo.h | 1 +
 util/cpuinfo-i386.c         | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/host/i386/cpuinfo.h b/include/host/i386/cpuinfo.h
index e6f7461378..a6537123cf 100644
--- a/include/host/i386/cpuinfo.h
+++ b/include/host/i386/cpuinfo.h
@@ -25,6 +25,7 @@
 #define CPUINFO_AVX512DQ        (1u << 14)
 #define CPUINFO_AVX512VBMI2     (1u << 15)
 #define CPUINFO_ATOMIC_VMOVDQA  (1u << 16)
+#define CPUINFO_ATOMIC_VMOVDQU  (1u << 17)
 
 /* Initialized with a constructor. */
 extern unsigned cpuinfo;
diff --git a/util/cpuinfo-i386.c b/util/cpuinfo-i386.c
index cb9475c688..b72374362f 100644
--- a/util/cpuinfo-i386.c
+++ b/util/cpuinfo-i386.c
@@ -77,8 +77,10 @@ unsigned __attribute__((constructor)) cpuinfo_init(void)
                  * See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104688
                  */
                 __cpuid(0, a, b, c, d);
-                if (c == signature_INTEL_ecx || c == signature_AMD_ecx) {
+                if (c == signature_INTEL_ecx) {
                     info |= CPUINFO_ATOMIC_VMOVDQA;
+                } else if (c == signature_AMD_ecx) {
+                    info |= CPUINFO_ATOMIC_VMOVDQA | CPUINFO_ATOMIC_VMOVDQU;
                 }
             }
         }
-- 
2.34.1
Re: [PATCH 3/9] util: Add i386 CPUINFO_ATOMIC_VMOVDQU
Posted by Peter Maydell 2 years, 8 months ago
On Thu, 18 May 2023 at 05:41, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Add a bit to indicate when VMOVDQU is also atomic if aligned.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/host/i386/cpuinfo.h | 1 +
>  util/cpuinfo-i386.c         | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM