[PATCH] ui/dbus: add a FIXME about texture/dmabuf scanout handling

marcandre.lureau@redhat.com posted 1 patch 11 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230515132537.1026310-1-marcandre.lureau@redhat.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
ui/dbus-listener.c | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] ui/dbus: add a FIXME about texture/dmabuf scanout handling
Posted by marcandre.lureau@redhat.com 11 months, 2 weeks ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Except SDL, display backends seem to fail at handing full scanout
geometry correctly. It would need some test/reproducer to actually check
it. In the meantime, fill some missing fields, and leave a FIXME.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 ui/dbus-listener.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
index defe2220c0..23034eebf9 100644
--- a/ui/dbus-listener.c
+++ b/ui/dbus-listener.c
@@ -102,6 +102,7 @@ static void dbus_scanout_dmabuf(DisplayChangeListener *dcl,
         return;
     }
 
+    /* FIXME: add missing x/y/w/h support */
     qemu_dbus_display1_listener_call_scanout_dmabuf(
         ddl->proxy,
         g_variant_new_handle(0),
@@ -129,6 +130,10 @@ static void dbus_scanout_texture(DisplayChangeListener *dcl,
         .width = backing_width,
         .height = backing_height,
         .y0_top = backing_y_0_top,
+        .x = x,
+        .y = y,
+        .scanout_width = w,
+        .scanout_height = h,
     };
 
     assert(tex_id);
-- 
2.40.1