target/loongarch: Terminate vmstate subsections list

[PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list

Posted by Richard Henderson 2 years, 9 months ago

This list requires a NULL terminator.

Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

This failure can be seen 

https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579

  5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test                 ERROR           1.38s   killed by signal 6 SIGABRT
 44/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/test-hmp                 ERROR           0.95s   killed by signal 6 SIGABRT
356/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/machine-none-test        ERROR           0.51s   killed by signal 6 SIGABRT

It does not always fail, depending on the layout of the executable,
which is why it was not caught right away.  I plan on applying this
directly to master before processing more pull requests.


r~

---
 target/loongarch/machine.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/loongarch/machine.c b/target/loongarch/machine.c
index 7adc1bdff9..d8ac99c9a4 100644
--- a/target/loongarch/machine.c
+++ b/target/loongarch/machine.c
@@ -163,5 +163,6 @@ const VMStateDescription vmstate_loongarch_cpu = {
     .subsections = (const VMStateDescription*[]) {
         &vmstate_fpu,
         &vmstate_lsx,
+        NULL
     }
 };
-- 
2.34.1

Re: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list

Posted by Philippe Mathieu-Daudé 2 years, 9 months ago

On 10/5/23 08:24, Richard Henderson wrote:
> This list requires a NULL terminator.
> 
> Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> 
> This failure can be seen
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579
> 
>    5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test                 ERROR           1.38s   killed by signal 6 SIGABRT
>   44/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/test-hmp                 ERROR           0.95s   killed by signal 6 SIGABRT
> 356/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/machine-none-test        ERROR           0.51s   killed by signal 6 SIGABRT
> 
> It does not always fail, depending on the layout of the executable,
> which is why it was not caught right away.  I plan on applying this
> directly to master before processing more pull requests.
> 
> 
> r~
> 
> ---
>   target/loongarch/machine.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list

Posted by Song Gao 2 years, 9 months ago


在 2023/5/10 下午2:24, Richard Henderson 写道:
> This list requires a NULL terminator.
>
> Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>
> This failure can be seen
>
> https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579
>
>    5/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test                 ERROR           1.38s   killed by signal 6 SIGABRT
>   44/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/test-hmp                 ERROR           0.95s   killed by signal 6 SIGABRT
> 356/789 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/machine-none-test        ERROR           0.51s   killed by signal 6 SIGABRT
>
> It does not always fail, depending on the layout of the executable,
> which is why it was not caught right away.  I plan on applying this
> directly to master before processing more pull requests.
>
Thank you.

We are adding this job to our internal CI process.

Thanks.
Song Gao